-
-
Notifications
You must be signed in to change notification settings - Fork 18
chore: migrate aspect_bazel_lib bazelrc to bazelrc-preset.bzl #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,16 @@ | ||
| # Import Aspect bazelrc presets | ||
| try-import %workspace%/.aspect/bazelrc/bazel7.bazelrc | ||
| import %workspace%/.aspect/bazelrc/convenience.bazelrc | ||
| import %workspace%/.aspect/bazelrc/correctness.bazelrc | ||
| import %workspace%/.aspect/bazelrc/debug.bazelrc | ||
| import %workspace%/.aspect/bazelrc/javascript.bazelrc | ||
| import %workspace%/.aspect/bazelrc/performance.bazelrc | ||
| import %workspace%/tools/preset.bazelrc | ||
|
|
||
| ### YOUR PROJECT SPECIFIC OPTIONS GO HERE ### | ||
|
|
||
| common --config=ruleset | ||
|
|
||
| # Don’t want to push a rules author to update their deps if not needed. | ||
| # https://bazel.build/reference/command-line-reference#flag--check_direct_dependencies | ||
| # https://bazelbuild.slack.com/archives/C014RARENH0/p1691158021917459?thread_ts=1691156601.420349&cid=C014RARENH0 | ||
| common --check_direct_dependencies=off | ||
|
|
||
| # Load any settings & overrides specific to the current user from `.aspect/bazelrc/user.bazelrc`. | ||
| # Load any settings & overrides specific to the current user. | ||
| # This file should appear in `.gitignore` so that settings are not shared with team members. This | ||
| # should be last statement in this config so the user configuration is able to overwrite flags from | ||
| # this file. See https://bazel.build/configure/best-practices#bazelrc-file. | ||
| try-import %workspace%/.aspect/bazelrc/user.bazelrc | ||
| try-import %workspace%/user.bazelrc | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| bazel-* | ||
| .bazelrc.user | ||
| user.bazelrc | ||
| node_modules/ | ||
| .pnpm-* | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1 @@ | ||
| # Import Aspect bazelrc presets | ||
| try-import %workspace%/../../.aspect/bazelrc/bazel7.bazelrc | ||
| import %workspace%/../../.aspect/bazelrc/convenience.bazelrc | ||
| import %workspace%/../../.aspect/bazelrc/correctness.bazelrc | ||
| import %workspace%/../../.aspect/bazelrc/debug.bazelrc | ||
| import %workspace%/../../.aspect/bazelrc/javascript.bazelrc | ||
| import %workspace%/../../.aspect/bazelrc/performance.bazelrc | ||
|
|
||
| ### YOUR PROJECT SPECIFIC OPTIONS GO HERE ### | ||
|
|
||
| # Load any settings & overrides specific to the current user from `.aspect/bazelrc/user.bazelrc`. | ||
| # This file should appear in `.gitignore` so that settings are not shared with team members. This | ||
| # should be last statement in this config so the user configuration is able to overwrite flags from | ||
| # this file. See https://bazel.build/configure/best-practices#bazelrc-file. | ||
| try-import %workspace%/../../.aspect/bazelrc/user.bazelrc | ||
| import %workspace%/../../tools/preset.bazelrc |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1 @@ | ||
| # Import Aspect bazelrc presets | ||
| try-import %workspace%/../../.aspect/bazelrc/bazel7.bazelrc | ||
| import %workspace%/../../.aspect/bazelrc/convenience.bazelrc | ||
| import %workspace%/../../.aspect/bazelrc/correctness.bazelrc | ||
| import %workspace%/../../.aspect/bazelrc/debug.bazelrc | ||
| import %workspace%/../../.aspect/bazelrc/javascript.bazelrc | ||
| import %workspace%/../../.aspect/bazelrc/performance.bazelrc | ||
|
|
||
| ### YOUR PROJECT SPECIFIC OPTIONS GO HERE ### | ||
|
|
||
| # Load any settings & overrides specific to the current user from `.aspect/bazelrc/user.bazelrc`. | ||
| # This file should appear in `.gitignore` so that settings are not shared with team members. This | ||
| # should be last statement in this config so the user configuration is able to overwrite flags from | ||
| # this file. See https://bazel.build/configure/best-practices#bazelrc-file. | ||
| try-import %workspace%/../../.aspect/bazelrc/user.bazelrc | ||
| import %workspace%/../../tools/preset.bazelrc |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1 @@ | ||
| # Import Aspect bazelrc presets | ||
| try-import %workspace%/../../.aspect/bazelrc/bazel7.bazelrc | ||
| import %workspace%/../../.aspect/bazelrc/convenience.bazelrc | ||
| import %workspace%/../../.aspect/bazelrc/correctness.bazelrc | ||
| import %workspace%/../../.aspect/bazelrc/debug.bazelrc | ||
| import %workspace%/../../.aspect/bazelrc/javascript.bazelrc | ||
| import %workspace%/../../.aspect/bazelrc/performance.bazelrc | ||
|
|
||
| ### YOUR PROJECT SPECIFIC OPTIONS GO HERE ### | ||
|
|
||
| # Load any settings & overrides specific to the current user from `.aspect/bazelrc/user.bazelrc`. | ||
| # This file should appear in `.gitignore` so that settings are not shared with team members. This | ||
| # should be last statement in this config so the user configuration is able to overwrite flags from | ||
| # this file. See https://bazel.build/configure/best-practices#bazelrc-file. | ||
| try-import %workspace%/../../.aspect/bazelrc/user.bazelrc | ||
| import %workspace%/../../tools/preset.bazelrc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should add
common --config=rulesetThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think
config=rulesetshould removelockfile_modewhichconfig=cienables? With rulesets we often want to test with multiple bazel versions which is causing issues for me in multiple repos right now, that's why I'm only updating tobazelrc-preset.bzl1.5 and not latest...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Someone made a case that rulesets should check in a lockfile, I personally agree with you that it's a PITA with no value