Conversation
|
I did expect some CI to fail but not pretty much everything. How can I test it locally? I was doing In any case, I'll try to pin down the issue. You don't need to do full review, just let me know if approach is sane. |
|
See draft PR #1510 as a partial solution to your CI problems... But after pulling your branch and cherry-picking the changes for #1510 it appears that your implementation is not recognizing that when For example when I try the build the esp32boot target I get an internal error from PackBeam: PackBeam should be creating the file |
|
I don't think #1510 should be necessary, but the help in the current |
|
Also, one feature missing from the C implementation that the pure erlang module has is a |
| free(file_data.data); | ||
| return ret; | ||
| } | ||
| TRY(safe_read_file(output_file, &file_data)); |
There was a problem hiding this comment.
This looks like a problem. Trying to read and verify that the not yet created avm archive is valid... this check should be done after the files have been packed into the output archive.
There was a problem hiding this comment.
I can successfully create an archive with lines 209-214 commented out.
Use atomvm_packbeam instead of built-in C packbeam Kept the remove lines for release avm builds. Install packbeam escript as bin/packbeam Obsoletes #1429 Requires atomvm/atomvm_packbeam#47 Adding -p for runnable would be a good thing but requires atomvm/atomvm_packbeam#60 These changes are made under both the "Apache 2.0" and the "GNU Lesser General Public License 2.1 or later" license terms (dual license). SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later
|
Obsoleted by #1793 |
3 participants
I went and implemented my suggestion from #1394.
I didn't do any thorough checks yet since I want to get feedback first (
make -jinbuild/doesn't crash on my machine).Worked on original file, slowly refactoring to what I had in mind. Do we have tests for packbeam or we only check it by usage?
Leaving all commits for now, will squash after acceptance.
TRYmacro that checks bool output from expression and iffalse, stops the execution of current function.booloutput to check for errors.perrorfor internals?).These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later