Skip to content

Use atomvm_packbeam instead of built-in C packbeam#1793

Merged
bettio merged 1 commit intoatomvm:mainfrom
pguyot:w32/single-packbeam
Feb 27, 2026
Merged

Use atomvm_packbeam instead of built-in C packbeam#1793
bettio merged 1 commit intoatomvm:mainfrom
pguyot:w32/single-packbeam

Conversation

@pguyot
Copy link
Collaborator

@pguyot pguyot commented Aug 10, 2025

Kept the remove lines for release avm builds.
Install packbeam escript as bin/packbeam

Obsoletes #1429
Requires atomvm/atomvm_packbeam#47

Adding -p for runnable would be a good thing but requires atomvm/atomvm_packbeam#60

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

@pguyot pguyot force-pushed the w32/single-packbeam branch 3 times, most recently from 3d8ecda to dd3936f Compare August 10, 2025 17:47
Copy link
Collaborator

@UncleGrumpy UncleGrumpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement, and should simply maintenance - focusing our efforts on a single implementation of packbeam.

This should probably include a mention that it supersedes #1429.

Copy link
Collaborator

@bettio bettio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this change but I think we should vendor here the tool we use for making .avm files. So we can build without any network access and make happy people trying to use Nix.

@pguyot pguyot force-pushed the w32/single-packbeam branch from dd3936f to a4d5477 Compare October 5, 2025 08:27
@UncleGrumpy
Copy link
Collaborator

UncleGrumpy commented Oct 5, 2025

Would including atomvm_packbeam here as a git submodule be enough to keep the nix people happy?
I think it is best kept as a stand alone repo since the atomvm_rebar3_plugin (and maybe eventually ExAtomVM) depend on it as well.

@pguyot pguyot force-pushed the w32/single-packbeam branch from a4d5477 to 378d6f3 Compare November 29, 2025 21:50
@pguyot pguyot marked this pull request as draft November 29, 2025 21:59
@pguyot pguyot force-pushed the w32/single-packbeam branch from 378d6f3 to 75a3519 Compare November 29, 2025 22:24
@pguyot pguyot force-pushed the w32/single-packbeam branch 2 times, most recently from 22ca4a2 to 866bb47 Compare December 7, 2025 16:56
@pguyot pguyot force-pushed the w32/single-packbeam branch 2 times, most recently from c92bdb5 to acd9e72 Compare January 24, 2026 09:19
@pguyot pguyot force-pushed the w32/single-packbeam branch 3 times, most recently from 8034ca8 to 6f8c3ed Compare February 22, 2026 12:03
@pguyot pguyot marked this pull request as ready for review February 22, 2026 19:35
Signed-off-by: Paul Guyot <pguyot@kallisys.net>
@bettio bettio merged commit dc2e5f1 into atomvm:main Feb 27, 2026
191 of 192 checks passed
@pguyot pguyot mentioned this pull request Feb 27, 2026
@pguyot pguyot deleted the w32/single-packbeam branch February 28, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants