test: macOS-insiders CI needs Node 22 + test-electron 3.0.0 (2.5.2 insufficient)#153
Draft
laileni-aws wants to merge 1 commit into
Draft
test: macOS-insiders CI needs Node 22 + test-electron 3.0.0 (2.5.2 insufficient)#153laileni-aws wants to merge 1 commit into
laileni-aws wants to merge 1 commit into
Conversation
The 'test macOS (18.x, insiders)' job fails repo-wide (incl. on main) with 'spawn .../Contents/MacOS/Electron ENOENT': the pinned @vscode/test-electron 2.3.8 (2023) can't locate the executable in the current VS Code Insiders macOS build. Bump to the latest Node-18-safe line (2.5.2). Note: the newest @vscode/test-electron (3.0.0) would be the most complete fix but requires Node >=22 (CI runs Node 18) and restructures the internal out/runTest import, so it is out of scope here. If 2.5.2 does not fully resolve the insiders job, the follow-up is a coordinated Node 22 + test-electron 3.0.0 upgrade.
laileni-aws
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: 2.5.2 does NOT fix the macOS-insiders job (CI-confirmed)
Bumping
@vscode/test-electron2.3.8 → 2.5.2was validated in CI and thetest macOS (18.x, insiders)job still fails with the identical error:So the fix is not present in any Node-18-compatible
@vscode/test-electron(latest 2.x = 2.5.2, from 2024, predates the VS Code Insiders build-layout change).Root cause & the real fix
@vscode/test-electron2.x resolves an executable path that no longer exists →ENOENT.@vscode/test-electron@3.0.0, but that requiresnode >= 22while this repo's CI runs Node 18, and 3.0.0 also restructures the internalout/runTestimport the repo uses.@vscode/test-electronto 3.0.0, and adjust theTestOptions/out/runTestimport. That's a repo-wide CI decision, larger than a dependency bump.This failure is pre-existing and repo-wide (fails on
mainand other PRs) and is unrelated to the dependency-security PRs.Recommendation: hold/close this PR in favor of the Node 22 + test-electron 3.0.0 upgrade (maintainer decision).