Skip to content

feat: animated drop-to-upload overlay with per-folder-row targeting#22

Merged
baronunread merged 1 commit into
mainfrom
feat/issue-12-drop-overlay
Jul 17, 2026
Merged

feat: animated drop-to-upload overlay with per-folder-row targeting#22
baronunread merged 1 commit into
mainfrom
feat/issue-12-drop-overlay

Conversation

@baronunread

Copy link
Copy Markdown
Owner

Fixes #12

What

  • Animated "Drop to upload" overlay — fades/scales in via motion with a softly pulsing dashed ring, and names the destination: Drop to upload to <folder>.
  • Drop into a specific folder row — while dragging files from the OS, the folder row under the cursor lights up as the drop target (same style as internal drag-move) and the overlay switches to naming it; dropping uploads into that folder instead of the folder being viewed.

How

  • The Host contract gains onFileDragHover: Tauri's native drag enter/over positions (converted from physical to CSS pixels) stream to the UI; leave emits null. A drop deliberately emits nothing here — the drop handler owns resetting hover state, so the hovered target can't be cleared out from under an in-flight drop while dropped paths are being expanded.
  • This replaces the DOM dragenter counter, which was unreliable under Tauri (wry intercepts native drop handling to emit its own events).
  • Folder rows tag themselves with data-drop-prefix; the cursor is hit-tested against their rects (zero-size rects skipped, so unrendered rows can't match).
  • The Node test host and selftest host expose control.dragFileHover(position) so scenarios can drive the hover phases through the same seam as drops.

Verification

  • New scenario: drag in over empty space → overlay names the current folder; hover a folder row → row highlights and overlay names it; drop → the file's real bytes land under that folder's prefix in MinIO, and the overlay is gone.
  • bun run typecheck clean, 304 unit tests pass, full scenario suite pass.

🤖 Generated with Claude Code

@baronunread
baronunread force-pushed the feat/issue-12-drop-overlay branch from dfc54e0 to bd6308e Compare July 17, 2026 09:25
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@baronunread, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 42 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3ef911aa-e0fb-40d7-9886-9ebbd16dc7fb

📥 Commits

Reviewing files that changed from the base of the PR and between 9d1ecd8 and 48a84d9.

📒 Files selected for processing (11)
  • src/selftest/mount.tsx
  • src/services/appServices.ts
  • src/services/host.tauri.ts
  • src/services/host.ts
  • src/ui/RemoteBrowser.tsx
  • src/ui/browser/RemoteBrowserRow.tsx
  • src/ui/browser/RemoteBrowserTable.tsx
  • src/ui/services.ts
  • src/ui/theme.css
  • tests/scenarios/transfer.ts
  • tests/support/nodeHost.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/issue-12-drop-overlay

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The Host contract gains onFileDragHover: Tauri's native drag enter/over
positions (converted to CSS pixels) stream to the UI, replacing the DOM
dragenter counter wry made unreliable. The overlay animates in via
motion, names the destination folder, and hit-tests the cursor against
folder-row rects so dropping on a folder row uploads into that folder
with the row lit as the drop target.

Fixes #12

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@baronunread
baronunread force-pushed the feat/issue-12-drop-overlay branch from 260c9c6 to 48a84d9 Compare July 17, 2026 13:26
@baronunread
baronunread merged commit 5babe03 into main Jul 17, 2026
4 checks passed
@baronunread
baronunread deleted the feat/issue-12-drop-overlay branch July 17, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Clearer OS drag-drop: animated "Drop to upload" overlay + drop into a specific folder row

1 participant