fix: don't call router.refresh() after deleting a post#130
Open
julianbenegas wants to merge 1 commit intomainfrom
Open
fix: don't call router.refresh() after deleting a post#130julianbenegas wants to merge 1 commit intomainfrom
julianbenegas wants to merge 1 commit intomainfrom
Conversation
When a post is deleted, calling router.refresh() after router.push() causes an application error because Next.js tries to revalidate/render the deleted post page before the navigation completes. The fix: - In delete-comment-dialog: only call router.refresh() when a comment is deleted (not the whole post). When a post is deleted, just navigate away. - In moderator-delete-post-dialog: remove router.refresh() entirely since we're always navigating to a different page after deletion. This was our bug, not a Next.js bug - the race condition between push and refresh on a deleted resource caused the error.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a post is deleted, calling router.refresh() after router.push() causes
an application error because Next.js tries to revalidate/render the deleted
post page before the navigation completes.
The fix:
deleted (not the whole post). When a post is deleted, just navigate away.
we're always navigating to a different page after deletion.
This was our bug, not a Next.js bug - the race condition between push and
refresh on a deleted resource caused the error.