Skip to content

fix: don't call router.refresh() after deleting a post #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julianbenegas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: don't call router.refresh() after deleting a post #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/web/components/delete-comment-dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,16 @@ export function DeletePostOrCommentDialog() {
setDialog(null)
setError(null)
if (result.deletedPost) {
// Navigate to repo index - don't refresh since the post no longer exists
const path = window.location.pathname
const parts = path.split("/").filter(Boolean)
if (parts.length >= 2) {
router.push(`/${parts[0]}/${parts[1]}`)
}
} else {
// Only refresh if we're staying on the same page (comment deleted, not post)
router.refresh()
}
router.refresh()
} catch (err) {
setError(err instanceof Error ? err.message : "Failed to delete")
}
Expand Down
2 changes: 1 addition & 1 deletion apps/web/components/moderator-delete-post-dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ export function ModeratorDeletePostDialog() {
const { owner, repo } = await deletePost(dialog.postId)
setDialog(null)
setError(null)
// Navigate to repo index - don't refresh since the post no longer exists
router.push(`/${owner}/${repo}`)
router.refresh()
} catch (err) {
setError(err instanceof Error ? err.message : "Failed to delete")
}
Expand Down