Open
Conversation
Update the config parsing and overriding logics using the new engine API (using ConfigRepresentation.Unmarshal, removing Config.Override) internal/configfile: - Bind: change signature so it stores into a configparse.Representation instead of runner.Config directly (this allows to call repr.Unmarshal(&cfg) with the file config as base when needed rather than having to bookkeep fields that are set) - Parse: use repr.Unmarshal and refactor internals to use unmarshal-like signatures - Find: make it handle default paths cmd/benchttp: - adapt to new engine and configfile API - refactor
- Unmarshal -> ParseInto - Removal of runner.ConfigFields - implement testutil.MustMakeRequest
- use benchttptest.AssertEqualRunners
GregoryAlbouy
force-pushed
the
deps/bump-benchttp-sdk-to-v0.2
branch
from
445b99b to
7028625
Compare
GregoryAlbouy
changed the title
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #6 +/- ##
===========================================
- Coverage 60.49% 44.94% -15.55%
===========================================
Files 13 5 -8
Lines 281 198 -83
===========================================
- Hits 170 89 -81
+ Misses 103 99 -4
- Partials 8 10 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use latest version of
benchttp/engine(v0.1.1➡️v0.2.0) and fix breaking changes.Changes
Notes