Merged
Conversation
Kanabenki
added
A-Windowing
alice-i-cecile
approved these changes
Jan 23, 2024
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
I've carefully reviewed this commit-by-commit, and did not see any behavioral changes. I've also tested this on Windows, paying careful attention to the windowing-specific examples.
matiqo15
approved these changes
Jan 23, 2024
Member
matiqo15
left a comment
matiqo15
left a comment
There was a problem hiding this comment.
Looks good, tested on linux + wayland
Contributor
|
Ran the following examples on macos and confirmed they function as expected with this PR: |
rparrett
added
the
S-Ready-For-Final-Review
Member
|
ok for me on macOS, iOS, Android, WebGL2 and WebGPU |
mockersf
approved these changes
Jan 28, 2024
Closed
tjamaan
pushed a commit
to tjamaan/bevy
that referenced
this pull request
Feb 6, 2024
# Objective Get bevyengine#11257 changes merged. I rewrote them one by one checking each to ensure correctness. In particular, the window rescale logic changes to accomodate mut app access are double checked. Not all changes have been included as some of bevy_winit has since changed, and i am not confident including them. Namely, the `run_app_update_if_should` change. ### Notes to reviewers Review commits individually, use the "Hide whitespaces" diff display mode. ## Changelog * `bevy::window::WindowMoved`'s `entity` field has been renamed to `window` ## Migration Guide `bevy::window::WindowMoved`'s `entity` field has been renamed to `window`. This is to be more consistent with other windowing events. Consider changing usage: ```diff -window_moved.entity +window_moved.window ``` --------- Co-authored-by: François <mockersf@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Get #11257 changes merged.
I rewrote them one by one checking each to ensure correctness. In particular, the window rescale logic changes to accomodate mut app access are double checked. Not all changes have been included as some of bevy_winit has since changed, and i am not confident including them. Namely, the
run_app_update_if_shouldchange.Notes to reviewers
Review commits individually, use the "Hide whitespaces" diff display mode.
Changelog
Migration Guide
bevy::window::WindowMoved'sentityfield has been renamed towindow. This is to be more consistent with other windowing events.Consider changing usage: