bevy_animation: Abstract away interpolation#11501
Closed
valaphee wants to merge 3 commits intobevyengine:mainfrom
valaphee:abstract-animation-interpolation
Closed
bevy_animation: Abstract away interpolation#11501valaphee wants to merge 3 commits intobevyengine:mainfrom valaphee:abstract-animation-interpolation
valaphee wants to merge 3 commits intobevyengine:mainfrom
valaphee:abstract-animation-interpolation
Conversation
…ve todo for cubic_spline_interpolation
Member
|
I like the direction of this abstraction, but we should consider the interaction with #4482 (which could use some help over the finish line). |
Contributor
|
Closing this as superseded by the curve-based animation restructure (#15434). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Should be a non-breaking change as it is only internal
Theoretically lerp could also be abstracted to addition and subtraction and would remove the trait body, but for quats, slerp is used instead of lerp
Weights are also a little bit interesting as I needed a stride for the keyframes array, which is 1 for all other types, but the compiler should optimize it away.