Make Gilrs a normal resource on non-Wasm targets#12092
Merged
james7132 merged 9 commits intobevyengine:mainfrom Feb 26, 2024
Merged
Make Gilrs a normal resource on non-Wasm targets#12092james7132 merged 9 commits intobevyengine:mainfrom
james7132 merged 9 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
approved these changes
Feb 25, 2024
alice-i-cecile
added
C-Code-Quality
alice-i-cecile
added
the
S-Ready-For-Final-Review
Member
|
@james7132 CI failure looks real: broken import on WASM builds. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
# Objective Partially address bevyengine#888. Gilrs is initialized on a separate thread, and thus conditionally implements `Send`, and all platforms other than Wasm. This means the `NonSend` resource constraint is likely too conservative. ## Solution Relax the requirement, and conditionally derive Resource on a wrapper around it, using `SyncCell` to satisfy the `Sync` requirement on it.
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
# Objective Partially address bevyengine#888. Gilrs is initialized on a separate thread, and thus conditionally implements `Send`, and all platforms other than Wasm. This means the `NonSend` resource constraint is likely too conservative. ## Solution Relax the requirement, and conditionally derive Resource on a wrapper around it, using `SyncCell` to satisfy the `Sync` requirement on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Partially address #888. Gilrs is initialized on a separate thread, and thus conditionally implements
Send, and all platforms other than Wasm. This means theNonSendresource constraint is likely too conservative.Solution
Relax the requirement, and conditionally derive Resource on a wrapper around it, using
SyncCellto satisfy theSyncrequirement on it.