Add methods iter_resources and iter_resources_mut#12829
Merged
james7132 merged 8 commits intobevyengine:mainfrom Apr 3, 2024
Merged
Add methods iter_resources and iter_resources_mut#12829james7132 merged 8 commits intobevyengine:mainfrom
iter_resources and iter_resources_mut#12829james7132 merged 8 commits intobevyengine:mainfrom
Conversation
matiqo15
added
C-Feature
Member
Author
|
@coreh I'd like to get your review on this |
alice-i-cecile
approved these changes
Apr 1, 2024
Member
|
Clean and useful. I really want this for bevy_dev_tools, and I think it's a good building block regardless. |
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
BD103
approved these changes
Apr 1, 2024
Member
BD103
left a comment
BD103
left a comment
There was a problem hiding this comment.
Good implementation and documentation 👍
alice-i-cecile
added
S-Ready-For-Final-Review
Member
|
Waiting a day or two to see if we can get another set of eyes on this :) |
pablo-lua
suggested changes
Apr 1, 2024
Contributor
pablo-lua
left a comment
pablo-lua
left a comment
There was a problem hiding this comment.
I'm happy with the state of this and the unsafe parts looks pretty much straightforward, but I think we should probably add safety comments in the docs examples, just so we can show our unsafe parts in examples.
btw, there's a typo too.
james7132
requested changes
Apr 2, 2024
james7132
removed
the
S-Ready-For-Final-Review
Co-authored-by: James Liu <contact@jamessliu.com> Co-authored-by: Pablo Reinhardt <126117294+pablo-lua@users.noreply.github.com>
Co-authored-by: James Liu <contact@jamessliu.com>
pablo-lua
approved these changes
Apr 2, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
james7132
approved these changes
Apr 3, 2024
chompaa
pushed a commit
to chompaa/bevy
that referenced
this pull request
Apr 5, 2024
# Objective - Closes bevyengine#12019 - Related to bevyengine#4955 - Useful for dev_tools and networking ## Solution - Create `World::iter_resources()` and `World::iter_resources_mut()` --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com> Co-authored-by: James Liu <contact@jamessliu.com> Co-authored-by: Pablo Reinhardt <126117294+pablo-lua@users.noreply.github.com>
Member
|
Thank you to everyone involved with the authoring or reviewing of this PR! This work is relatively important and needs release notes! Head over to bevyengine/bevy-website#1296 if you'd like to help out. |
alice-i-cecile
removed
the
M-Release-Note
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
World::iter_resources()andWorld::iter_resources_mut()methods #12019Solution
World::iter_resources()andWorld::iter_resources_mut()