Implement FromIterator/IntoIterator for dynamic types

[SpecificProtagonist]

Objective

Implement FromIterator/IntoIterator for dynamic types where missing

Note:

• can't impl IntoIterator for &Array & co because of orphan rules
• into_iter().collect() is a no-op for Vecs because of specialization

---

Migration Guide

• Change DynamicArray::from_vec to DynamicArray::from_iter

[MrGVSV]

Awesome! I think these changes will be super useful!

[MrGVSV]

These are cool! I've been wanting a succinct way to create DynamicStruct and friends for a long time haha

[MrGVSV]

@SpecificProtagonist could you also update the title and description to account for your new changes?

[SpecificProtagonist]

@SpecificProtagonist could you also update the title and description to account for your new changes?

Yep – already updated the description; accidentally cancelled the edit to the title :3

Do you know what's going on with the compile error? It doesn't appear locally for me, and doesn't make any sense to me either: It says that the return type of Box::<[Box<dyn Reflect>]>::into_iter is [Box<dyn Reflect>], which isn't the case.

[MrGVSV]

Do you know what's going on with the compile error? It doesn't appear locally for me, and doesn't make any sense to me either: It says that the return type of Box::<[Box<dyn Reflect>]>::into_iter is [Box<dyn Reflect>], which isn't the case.

Looks like IntoIterator for Box<[T]> was recently merged and set to land in Rust 1.80.

For now, I'd recommend just doing:

self.values.into_vec().into_iter()

It might be a good idea also leaving a FIXME comment that links to that PR or maybe a Bevy issue to update it once 1.80 is out (in the next few weeks I think).

[SpecificProtagonist]

Thanks! Fixed it. Didn't leave a todo as the resulting code is fine.

I've also removed the homogeneous FromIterator impls from the types intended to be heterogeneous.

[mweatherley]

A couple minor comments, but nothing worth blocking over. Good feature!