update bevy_ecs MSRV to 1.89.0#21500
Closed
Victoronz wants to merge 3 commits intobevyengine:mainfrom
Closed
Conversation
Contributor
Author
|
Is this targeted, minimal upgrade more appropriate? |
alice-i-cecile
approved these changes
Oct 10, 2025
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Happy to bump this here. Our policy is "latest stable", and I like splitting this out.
alice-i-cecile
added
A-ECS
Contributor
|
Your PR increases Bevy Minimum Supported Rust Version. Please update the |
Member
|
Not unblocking the linked PR, which needs rust 1.91 which is not yet released. Bumping MSRV should be done in the PR that needs it, not on its own |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Update bevy_ecs MSRV to 1.89 to allow some functions to be turned const in #21498.
Solution
Update the MSRV.
Also fix the clippy lint concerning if && if let chaining that comes with the upgrade.