[Merged by Bors] - Move ambiguity detection into its own file#5918
Closed
alice-i-cecile wants to merge 4 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Move ambiguity detection into its own file#5918alice-i-cecile wants to merge 4 commits intobevyengine:mainfrom
alice-i-cecile wants to merge 4 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
added
A-ECS
afonsolage
reviewed
Sep 9, 2022
Contributor
afonsolage
left a comment
afonsolage
left a comment
There was a problem hiding this comment.
Since this PR is part of a bigger plan, does make sense to have all planned features in an tracking issue? So we may know what to expect in the future, like adding back the removed tests.
Member
Author
|
I'm working off the plan in #4299 (comment) |
mockersf
approved these changes
Sep 9, 2022
Member
Author
|
bors r+ |
alice-i-cecile
added
the
S-Ready-For-Final-Review
Member
Author
|
(merged with one approval due to triviality) |
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
nicopap
pushed a commit
to nicopap/bevy
that referenced
this pull request
Sep 12, 2022
# Objective This code is very disjoint, and the `stage.rs` file that it's in is already very long. All I've done is move the code and clean up the compiler errors that result. Followup to bevyengine#5916, split out from bevyengine#4299.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective This code is very disjoint, and the `stage.rs` file that it's in is already very long. All I've done is move the code and clean up the compiler errors that result. Followup to bevyengine#5916, split out from bevyengine#4299.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective This code is very disjoint, and the `stage.rs` file that it's in is already very long. All I've done is move the code and clean up the compiler errors that result. Followup to bevyengine#5916, split out from bevyengine#4299.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
This code is very disjoint, and the
stage.rsfile that it's in is already very long.All I've done is move the code and clean up the compiler errors that result.
Followup to #5916, split out from #4299.