[Merged by Bors] - early return from multithreaded executor#7521
Closed
hymm wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - early return from multithreaded executor#7521hymm wants to merge 1 commit intobevyengine:mainfrom
hymm wants to merge 1 commit intobevyengine:mainfrom
Conversation
alice-i-cecile
added
A-ECS
tim-blackbird
approved these changes
Feb 6, 2023
mockersf
approved these changes
Feb 6, 2023
mockersf
added
the
S-Ready-For-Final-Review
jakobhellermann
approved these changes
Feb 6, 2023
Member
|
This will need to be rebased on top of #7519. |
hymm
force-pushed
the
skip-zero-systems
branch
from
feb6850 to
b90f32f
Compare
bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2023
# Objective - There is a small perf cost for starting the multithreaded executor. ## Solution - We can skip that cost when there are zero systems in the schedule. Overall not a big perf boost unless there are a lot of empty schedules that are trying to run, but it is something. Below is a tracy trace of the run_fixed_update_schedule for many_foxes which has zero systems in it. Yellow is main and red is this pr. The time difference between the peaks of the humps is around 15us. 
Contributor
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Below is a tracy trace of the run_fixed_update_schedule for many_foxes which has zero systems in it. Yellow is main and red is this pr. The time difference between the peaks of the humps is around 15us.