Skip to content

Comments

BRE-1437 ci(build-bitwarden-lite): add ShellCheck step#449

Draft
fntyler wants to merge 1 commit intomainfrom
bre/bre-1437/shellcheck-workflow
Draft

BRE-1437 ci(build-bitwarden-lite): add ShellCheck step#449
fntyler wants to merge 1 commit intomainfrom
bre/bre-1437/shellcheck-workflow

Conversation

@fntyler
Copy link
Contributor

@fntyler fntyler commented Dec 31, 2025

🎟️ Tracking

BRE-1437

📔 Objective

Include step as part of setupto execute shellcheck before building container image.

  • option to install specific shellcheck version

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details47fe9d58-d41b-4f7f-aee1-03fafa347ce3

Great job! No new security vulnerabilities introduced in this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant