Set upper bounds for setuptools and wheel-filename#229
Open
mghantous wants to merge 2 commits intoblue-yonder:masterfrom
Open
Set upper bounds for setuptools and wheel-filename#229mghantous wants to merge 2 commits intoblue-yonder:masterfrom
mghantous wants to merge 2 commits intoblue-yonder:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds upper bounds to the
setuptoolsandwheel-filenamedependencies incore-requirements.txtto prevent installation of incompatible versions:setuptoolsis capped at <82 because version 82 dropspkg_resources.wheel-filenameis capped at <2 because version 2 breaks imports ofInvalidFilenameErrorandparse_wheel_filename.Note: I have fixes to remove the upper bounds in another PR, however it failed coverage and I didn't like the fact that I still had to set an upper bound for CI (due to devpi-server's devpi-init): #228
If someone would like to take over that other PR, then by all means, please do.
Also PS: Please push latest releases to pypi! Thank you.