Set upper bounds for setuptools and wheel-filename

[mghantous]

See blue-yonder#229 for description

[gemini-code-assist]

Summary of Changes

Hello @mghantous, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces specific upper version bounds for the setuptools and wheel-filename dependencies within the core-requirements.txt file. This change is crucial for maintaining compatibility and preventing potential breaking changes that would occur if newer, incompatible versions of these libraries were installed, thereby ensuring the stability of the project's environment.

Highlights

• setuptools version constraint: An upper bound of <82 was added to the setuptools dependency to prevent compatibility issues arising from version 82 dropping pkg_resources.
• wheel-filename version constraint: An upper bound of <2 was applied to the wheel-filename dependency to avoid breaking imports of InvalidFilenameError and parse_wheel_filename in version 2.

Changelog

• core-requirements.txt
  • Added an upper version bound for setuptools.
  • Added an upper version bound for wheel-filename.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/tests.yml

Activity

• No activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request sets upper bounds for setuptools and wheel-filename to prevent breakages from recent updates. The changes are correct and the included comments clearly explain the reasons. I've added a couple of suggestions for long-term maintainability, proposing to migrate away from deprecated or changed APIs in these dependencies as a follow-up.

[gemini-code-assist]

Pinning setuptools is a good immediate fix to prevent breakage from pkg_resources being removed. However, pkg_resources is deprecated. For a more robust long-term solution, you should consider migrating the code in devpi_builder/requirements.py to use modern alternatives like the packaging library (which is already a dependency) for name and version handling. This would remove the runtime dependency on setuptools and make the project more future-proof.

[gemini-code-assist]

Pinning wheel-filename is a good way to prevent breakage from the API changes in version 2. As a follow-up, it would be beneficial to create an issue to track updating the code in devpi_builder/wheeler.py to use the new API of wheel-filename>=2. This will ensure the project stays current with its dependencies and can benefit from future improvements.