Skip to content

Mark KeyViz adapter labels implemented #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bootjp wants to merge 1 commit into from
Closed

Mark KeyViz adapter labels implemented #1028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...6_04_28_proposed_keyviz_adapter_labels.md → ...4_28_implemented_keyviz_adapter_labels.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
status: proposed
status: implemented

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep adapter labels marked proposed until code lands

This status now advertises the adapter-label design as complete, but the current tree still lacks the implementation the document describes: keyviz.Sampler.Observe still has no label parameter (keyviz/sampler.go:79), there is no keyviz/labels.go from a repo-wide file search, and the JSON KeyVizRow still has no label field (internal/admin/keyviz_handler.go:86). In any checkout after this commit, design/status consumers will treat per-adapter KeyViz labels as available even though operators cannot enable --keyvizLabelsEnabled or get labeled rows, so this should remain proposed/partial until the implementation is present in the same tree.

Useful? React with 👍 / 👎.

phase: 2-C+
parent_design: docs/admin_ui_key_visualizer_design.md
author: bootjp
Expand Down Expand Up @@ -579,7 +579,7 @@ from PR #694: Claude bot critical, Gemini high.)
The fan-out aggregator's per-cell merge key gains the label:

- Phase 2-C (current): `(bucketID, raftGroupID, leaderTerm,
windowStart)` per design `2026_04_27_proposed_keyviz_cluster_fanout.md`
windowStart)` per design `2026_04_27_implemented_keyviz_cluster_fanout.md`

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3 Badge Point the fan-out reference at an existing design

This new reference is broken in the current tree: searching docs/design for *keyviz_cluster_fanout* only finds 2026_04_27_proposed_keyviz_cluster_fanout.md, not the implemented filename used here. If this commit is browsed or checked before the dependent rename lands, readers and link checkers are sent to a non-existent design; keep the proposed filename until the dependency is included, or include the referenced rename in this change.

Useful? React with 👍 / 👎.

§4.
- With labels: same tuple — but `bucketID` itself now carries the
label via the §5 composite (`route:1:dynamo`). The merge key
Expand Down
Loading