Mark KeyViz adapter labels implemented

[bootjp]

Author: bootjp

Summary

• mark the KeyViz adapter-label design as implemented
• update its cluster fan-out design reference

Dependency

• Depends on Mark KeyViz cluster fanout implemented #1025 for the cluster fan-out implemented design filename.

Verification

• git diff --check
• commit signature verified with git verify-commit HEAD

[bootjp]

@codex review

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a919b4d8-c042-4413-85cb-0b35499fbb35

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch design/promote-keyviz-adapter-labels-doc

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[gemini-code-assist]

Code Review

This pull request updates the design document 2026_04_28_implemented_keyviz_adapter_labels.md to change its status from 'proposed' to 'implemented' and updates a reference to another design document to reflect its 'implemented' status. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3adbf372ad

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Keep adapter labels marked proposed until code lands

This status now advertises the adapter-label design as complete, but the current tree still lacks the implementation the document describes: keyviz.Sampler.Observe still has no label parameter (keyviz/sampler.go:79), there is no keyviz/labels.go from a repo-wide file search, and the JSON KeyVizRow still has no label field (internal/admin/keyviz_handler.go:86). In any checkout after this commit, design/status consumers will treat per-adapter KeyViz labels as available even though operators cannot enable --keyvizLabelsEnabled or get labeled rows, so this should remain proposed/partial until the implementation is present in the same tree.

Useful? React with 👍 / 👎.

[chatgpt-codex-connector]

Point the fan-out reference at an existing design

This new reference is broken in the current tree: searching docs/design for *keyviz_cluster_fanout* only finds 2026_04_27_proposed_keyviz_cluster_fanout.md, not the implemented filename used here. If this commit is browsed or checked before the dependent rename lands, readers and link checkers are sent to a non-existent design; keep the proposed filename until the dependency is included, or include the referenced rename in this change.

Useful? React with 👍 / 👎.

[bootjp]

adapter-label support is not present in the current tree yet, so this promotion should not land as implemented. Closing this draft until the sampler/API/UI implementation is added.