feat(tools): real-data observability / null-space-leak diagnostic#424
Merged
Conversation
Adds obs_inspect, the real-data companion to the synthetic observability_probe (#337). It taps every MSCKF update over a real EuRoC sequence and drives the SHIPPED CameraUpdater::projection_jacobians over the live clone window + triangulated feature, measuring the per-direction gauge leak ‖H·N‖ for the 4-DoF unobservable subspace (global translation x3 + yaw x1): - consistent leak (H and N at the same estimate): the gauge-annihilation sanity check — must be ~machine-eps, confirming the production Jacobian is correct; - real leak (H perturbed by the filter's OWN per-clone sigma from P, N at the unperturbed gauge): the synthetic sigma-sweep evaluated at the uncertainty the filter actually reports on this window. On V2_03_difficult the consistent leak is ~1e-15 (Jacobian correct), the translation leak is structurally 0 (the +/-Hf cancellation protects it), and the yaw leak is nonzero on 100% of updates and grows with the clone window's attitude drift (sigma_theta to 5.6 deg) — localizing the #212 over-confidence to the yaw gauge on real data, and pointing at the right-invariant (R-IEKF) fix. The testable core (build_H/build_N/leak) lives in a header using fully-qualified types (no `using namespace`, so it composes with the backend headers); the EuRoC driver is read-only and not a CI gate. The gauge property is gated by tests/tools/observability_inspect.cpp on a constructed clone window. Relates to #212, #337 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
obs_inspect, the real-data companion to the syntheticobservability_probe(#337). It localizes the #212 over-confidence to the yaw gauge on real EuRoC data — the first per-update measurement of the null-space leak on a real sequence.What it measures
A monocular VIO has a 4-DoF unobservable gauge — global translation (3) + rotation-about-gravity, yaw (1). A consistent filter must never gain information along it: the stacked camera Jacobian must annihilate the gauge, ‖H·N‖ ≈ 0. That holds only at a single consistent linearization; a standard EKF re-linearizes each clone at its own drifted estimate, so the gauge leaks and the filter fabricates information → over-confidence.
obs_inspecttaps every MSCKF update, drives the shippedCameraUpdater::projection_jacobiansover the live clone window + triangulated feature, and reports two leaks per update:Measured result (V2_03_difficult, 2,918 updates)
→ localizes #212 to yaw, pointing at the right-invariant (R-IEKF) fix (estimate-independent gauge directions).
Changes
tools/include/branes/tools/observability_inspect.hpp— testable core (build_H/build_N/leak), fully-qualified types so it composes with the backend headers (nousing namespaceVec3-ambiguity).tools/src/obs_inspect.cpp— EuRoC driver (read-only, not a CI gate).tests/tools/observability_inspect.cpp— gates the gauge property on a constructed clone window.tools/README.md— entry + section.Test Results
Test plan
Relates to #212, #337
🤖 Generated with Claude Code