Fix Windows install branding constants#1003
Open
Stephen Karl Larroque (lrq3000) wants to merge 1 commit into
Open
Fix Windows install branding constants#1003Stephen Karl Larroque (lrq3000) wants to merge 1 commit into
Stephen Karl Larroque (lrq3000) wants to merge 1 commit into
Conversation
Agent-Logs-Url: https://github.com/lrq3000/BrowserOS/sessions/aca7c90e-815e-41b0-b423-616b591ae881 Co-authored-by: lrq3000 <1118942+lrq3000@users.noreply.github.com>
Contributor
|
PR author is not in the allowed authors list. |
Contributor
|
Thank you for your contribution! Before we can merge this PR, we need you to sign our Contributor License Agreement. To sign the CLA, please add a comment to this PR with the following text: You only need to sign once. After signing, this check will pass automatically. Troubleshooting
|
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
I repeat: I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
Author
|
I think the CLA bot is breaking here because it thinks the GitHub Copilot bot is a commit author that also needs to sign the CLA, which is not possible. This will require manual intervention by a human maintainer of BrowserOS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
PR generated with Copilot cloud agent using GPT-5.2-codex.
I could not test the fix myself because I could not compile, I don't have the required stack, but I reviewed the code change and the logic and the fix makes sense to me.
Please test beforehand to check if it works (if someone can make a build - maybe by triggering a gh action - I will gladly try !).
Summary by cubic
Update Windows install identity to use BrowserOS branding. Ensures install paths and Safe Browsing client name are correct and adds a test to prevent regressions.
kCompanyPathNameandkProductPathNameto "BrowserOS" andkSafeBrowsingNameto "browseros" inpackages/browseros/chromium_patches/chrome/install_static/chromium_install_modes.h.packages/browseros/tests/test_install_modes_patch.pyto assert the constants and guard future changes.Written for commit c03ccd4. Summary will update on new commits.
This specific bug is Windows-only. The constants we changed live under chrome/install_static (Windows install path/registry identity). macOS/Linux installs use different mechanisms and aren’t affected by these Windows install identity values.
Agent-Logs-Url: https://github.com/lrq3000/BrowserOS/sessions/aca7c90e-815e-41b0-b423-616b591ae881