Skip to content

Fix Windows install branding constants#1003

Open
Stephen Karl Larroque (lrq3000) wants to merge 1 commit into
browseros-ai:mainfrom
lrq3000:dev
Open

Fix Windows install branding constants#1003
Stephen Karl Larroque (lrq3000) wants to merge 1 commit into
browseros-ai:mainfrom
lrq3000:dev

Conversation

@lrq3000
Copy link
Copy Markdown

Summary

Testing

  • python -m unittest discover -s packages/browseros/tests

PR generated with Copilot cloud agent using GPT-5.2-codex.

I could not test the fix myself because I could not compile, I don't have the required stack, but I reviewed the code change and the logic and the fix makes sense to me.

Please test beforehand to check if it works (if someone can make a build - maybe by triggering a gh action - I will gladly try !).


Summary by cubic

Update Windows install identity to use BrowserOS branding. Ensures install paths and Safe Browsing client name are correct and adds a test to prevent regressions.

  • Bug Fixes
    • Set kCompanyPathName and kProductPathName to "BrowserOS" and kSafeBrowsingName to "browseros" in packages/browseros/chromium_patches/chrome/install_static/chromium_install_modes.h.
    • Added packages/browseros/tests/test_install_modes_patch.py to assert the constants and guard future changes.

Written for commit c03ccd4. Summary will update on new commits.

This specific bug is Windows-only. The constants we changed live under chrome/install_static (Windows install path/registry identity). macOS/Linux installs use different mechanisms and aren’t affected by these Windows install identity values.

Agent-Logs-Url: https://github.com/lrq3000/BrowserOS/sessions/aca7c90e-815e-41b0-b423-616b591ae881

Agent-Logs-Url: https://github.com/lrq3000/BrowserOS/sessions/aca7c90e-815e-41b0-b423-616b591ae881

Co-authored-by: lrq3000 <1118942+lrq3000@users.noreply.github.com>
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 15, 2026

PR author is not in the allowed authors list.

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution! Before we can merge this PR, we need you to sign our Contributor License Agreement.

To sign the CLA, please add a comment to this PR with the following text:

I have read the CLA Document and I hereby sign the CLA

You only need to sign once. After signing, this check will pass automatically.


Troubleshooting
  • Already signed but still failing? Comment recheck to trigger a re-verification.
  • Signed with a different email? Make sure your commit email matches your GitHub account email, or add your commit email to your GitHub account.
- - - I have read the CLA Document and I hereby sign the CLA - - - You can retrigger this bot by commenting **recheck** in this Pull Request. Posted by the **CLA Assistant Lite bot**.

@lrq3000
Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@lrq3000
Copy link
Copy Markdown
Author

I repeat: I have read the CLA Document and I hereby sign the CLA

@lrq3000
Copy link
Copy Markdown
Author

recheck

@lrq3000
Copy link
Copy Markdown
Author

I think the CLA bot is breaking here because it thinks the GitHub Copilot bot is a commit author that also needs to sign the CLA, which is not possible. This will require manual intervention by a human maintainer of BrowserOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installer overwrites existing Chromium installation instead of separate install

2 participants