Skip to content

Fix Windows install branding constants #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Stephen Karl Larroque (lrq3000) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Windows install branding constants #1003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/browseros/chromium_patches/chrome/install_static/chromium_install_modes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,18 @@ diff --git a/chrome/install_static/chromium_install_modes.h b/chrome/install_sta
index ee62888f89705..7ec72d302bc4b 100644
--- a/chrome/install_static/chromium_install_modes.h
+++ b/chrome/install_static/chromium_install_modes.h
@@ -21,7 +21,7 @@ inline constexpr wchar_t kCompanyPathName[] = L"";
@@ -21,9 +21,9 @@ inline constexpr wchar_t kCompanyPathName[] = L"";
-inline constexpr wchar_t kCompanyPathName[] = L"";
+inline constexpr wchar_t kCompanyPathName[] = L"BrowserOS";

// The brand-specific product name to be included as a component of the install
// and user data directory paths.
-inline constexpr wchar_t kProductPathName[] = L"Chromium";
+inline constexpr wchar_t kProductPathName[] = L"BrowserOS";

// The brand-specific safe browsing client name.
inline constexpr char kSafeBrowsingName[] = "chromium";
-inline constexpr char kSafeBrowsingName[] = "chromium";
+inline constexpr char kSafeBrowsingName[] = "browseros";
@@ -44,48 +44,49 @@ inline constexpr auto kInstallModes = std::to_array<InstallConstants>({
L"", // Empty install_suffix for the primary install mode.
.logo_suffix = L"", // No logo suffix for the primary install mode.
Expand Down
23 changes: 23 additions & 0 deletions packages/browseros/tests/test_install_modes_patch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import unittest
from pathlib import Path


PATCH_PATH = (
Path(__file__).resolve().parents[1]
/ "chromium_patches"
/ "chrome"
/ "install_static"
/ "chromium_install_modes.h"
)


class InstallModesPatchTest(unittest.TestCase):
def test_install_identity_is_browseros(self) -> None:
content = PATCH_PATH.read_text(encoding="utf-8")
self.assertIn('kCompanyPathName[] = L"BrowserOS"', content)
self.assertIn('kProductPathName[] = L"BrowserOS"', content)
self.assertIn('kSafeBrowsingName[] = "browseros"', content)


if __name__ == "__main__":
unittest.main()
Loading