fix(newtab): prevent null/chat navigation when search message is empty#906
Open
listende-elg wants to merge 1 commit into
Open
fix(newtab): prevent null/chat navigation when search message is empty#906listende-elg wants to merge 1 commit into
listende-elg wants to merge 1 commit into
Conversation
When the search field on the new tab page is submitted with an empty or null message, URLSearchParams coerces null to the string 'null', causing navigation to /null/chat and a ERR_FILE_NOT_FOUND error. Add validation in 4 locations: - startInlineChat(): guard against null/empty messages - handleSend(): only execute default action when inputValue has content - executeDefaultAction(): only run action if selectedItem exists - runSelectedAction(): validate browseros item has a message before use Fixes browseros-ai#775
Contributor
|
PR author is not in the allowed authors list. |
Contributor
|
All contributors have signed the CLA. Thank you! |
Author
|
recheck |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the search field on the new tab page is submitted with an empty or null message, URLSearchParams coerces null to the string 'null', causing navigation to /null/chat and a ERR_FILE_NOT_FOUND error.
Add validation in 4 locations:
Fixes #775