Skip to content

fix(newtab): prevent null/chat navigation when search message is empty #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
listende-elg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(newtab): prevent null/chat navigation when search message is empty #906

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions packages/browseros-agent/apps/agent/entrypoints/newtab/index/NewTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,20 +306,32 @@ export const NewTab = () => {
const selectedItem = flatItems[highlightedIndex]
runSelectedAction(selectedItem)
} else {
executeDefaultAction()
// FIX: Only execute default action if inputValue has content
if (inputValue && inputValue.trim() !== '') {
executeDefaultAction()
}
}
}

const executeDefaultAction = () => {
const selectedItem = flatItems[0]
runSelectedAction(selectedItem)
// FIX: Only run action if selectedItem exists
if (selectedItem) {
runSelectedAction(selectedItem)
}
}

const startInlineChat = (
message: string,
chatMode: 'chat' | 'agent',
aiTab?: { name: string; description: string },
) => {
// FIX: Validate message is not null/undefined/empty
if (!message || message.trim() === '') {
console.warn('startInlineChat: message is empty, using default')
message = 'Help'
}

track(NEWTAB_CHAT_STARTED_EVENT, {
mode: chatMode,
tabs_count: selectedTabs.length,
Expand All @@ -329,7 +341,8 @@ export const NewTab = () => {
.filter((id): id is number => id !== undefined)
reset()
setSelectedTabs([])
const params = new URLSearchParams({ q: message, mode: chatMode })
// FIX: Ensure message is a valid string for URLSearchParams
const params = new URLSearchParams({ q: String(message), mode: chatMode })
if (tabIds.length > 0) {
params.set('tabs', tabIds.join(','))
}
Expand Down Expand Up @@ -386,6 +399,11 @@ export const NewTab = () => {
mode: item.mode,
tabs_count: selectedTabs.length,
})
// FIX: Validate item.message before using it
if (!item.message) {
console.warn('runSelectedAction: browseros item has no message')
return
}
if (supportsInlineChat) {
startInlineChat(item.message, item.mode)
} else {
Expand Down
Loading