Conversation
We bumped to Go 1.23 support in #14, so we don't need to run our workflow on an unsupported version. Just run based on the go version in go.mod.
|
Shouldn't we move it to test Go 1.24? (and Go 1.25, I suppose.) |
stefanvanburen
changed the title
Done. I guess we could also bump the go.mod to 1.24 here now that 1.25 is out following our support policy, but can also just leave it. I'm also a little confused as to why the CI job isn't running, I guess because I'm editing it in this PR? |
|
I have no clue why the workflow isn't running. I guess it would probably work, but we should maybe figure it out. |
Otherwise, we have churn in CI due to the generated files changing.
Just ran it locally against this branch and it failed for an unrelated reason: https://github.com/bufbuild/bufplugin-go/actions/runs/17328800947. Pushed a fix in b6673e7, and looks like the matrix is running properly in that commit. So going to merge this if those pass. |
|
Yeah, @DMarby sniped the issue: the workflow got disabled since it hadn't run for 60 days. I re-enabled it. Thanks David! |
huh! did not even know that's a thing. thank you both for fixing that! |
1 participant
We bumped to Go 1.23 support in #14, so we don't need to run our workflow on an unsupported version. Just run based on the go version in go.mod.