Add SF Symbol row icons to sidebar server, channel, and PM rows#32
Merged
Add SF Symbol row icons to sidebar server, channel, and PM rows#32
Conversation
This was referenced Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.disconnectedstate — same idiom aswifi.slash,microphone.slash. Transient.connecting/.disconnectingstates keep the active icon and let the existing dot color carry the signal so the icon doesn't flash mid-handshake.#stripping on channel names;#linuxstill renders as#linux. The icon is purely additive.Changes
Sources/Brygga/Views/ContentView.swift:ServerRow— adds anImage(systemName: serverIconName)between the existing connection-stateCircleand the server-nameText. New privateserverIconNamereturns"antenna.radiowaves.left.and.right.slash.circle.fill"whenstate == .disconnectedand"antenna.radiowaves.left.and.right.circle.fill"otherwise.ChannelRow— adds anImageat the start of itsHStack."number.circle.fill"for regular channels,"person.crop.circle.fill"for PMs (channel.isPrivateMessage)..secondaryforeground style — same weight as the existingchevron.down/moon.fillaccents in the row, so they sit visually below the colored connection dot and the channel name.Test plan
swift build— passesswift test— 131 tests pass (no test changes; UI-only)swiftformat --lint .— clean● ⊕ Liberastyle row (state dot + antenna-in-circle icon + name)./quit). The icon flips to the slash variant, the dot turns grey..connectingwindow, dot is yellow but the icon stays unslashed.#swift— sidebar row shows(number-in-circle) #swift. The#is preserved in the name.ChanServ— row shows(person-in-circle) ChanServ..circle.fillfamily so they share weight and cap height.Risk / rollback
antenna.radiowaves.left.and.right.slash.circle.fillis shipped in macOS 15 SF Symbols; the deployment floor is already 15.