Mongo breadcrumb: Add "sort" field#798
Open
johnnyshields wants to merge 3 commits intobugsnag:masterfrom
Open
Conversation
johnnyshields
changed the title
|
Hi @johnnyshields |
clr182
added
feature request
Contributor
Author
|
Here is evidence of this working:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Add "sort" field to breadcrumb for MongoDB queries. Sort can have significant bearing on index selection/performance, and its very useful to see.
Design
The implementation mirrors how the "filter" field is captured today. Unlike filters, we don't need to mask the values because they can only be 1 or -1.
Changeset
The Mongo breadcrumb functionality only.
This also includes the changes from #797 b/c I cannot commit from my Windows machine otherwise.
Testing
Tested in RSpec and by TableCheck in production.