Add test coverage for error re-catch after reset#244
Merged
Conversation
This test verifies that when an error boundary resets (via resetKeys change) but the child component still throws, the error boundary catches the error again and displays the fallback. Previously this edge case was marked as a TODO and had no test coverage.
|
@hiro-nikaitou is attempting to deploy a commit to the Brian Vaughn's projects Team on Vercel. A member of the Team first needs to authorize it. |
bvaughn
approved these changes
Jul 12, 2026
bvaughn
left a comment
bvaughn
left a comment
Owner
There was a problem hiding this comment.
Oh, thanks. Had forgotten about those TODO comments :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test case for one of the remaining TODO items in ErrorBoundary.test.tsx:
The test verifies that when an error boundary resets (via
resetKeyschange) but the child component continues to throw, the error boundary catches the error again and displays the fallback.Previously this case had no test coverage.