Skip to content

Add test coverage for error re-catch after reset #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bvaughn merged 1 commit into from
Jul 12, 2026
+9 −1
Merged

Add test coverage for error re-catch after reset #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/components/ErrorBoundary.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,15 @@ describe("ErrorBoundary", () => {
expect(container.textContent).toBe("Content");
});

it("should catch errors thrown again after reset", () => {
shouldThrow = true;
render({ resetKeys: [1] });
expect(container.textContent).toBe("Error");

render({ resetKeys: [2] });
expect(container.textContent).toBe("Error");
});

it("should render a null fallback if specified", () => {
shouldThrow = true;
act(() => {
Expand Down Expand Up @@ -359,6 +368,5 @@ describe("ErrorBoundary", () => {
});

// TODO Various cases with resetKeys changing (length, order, etc)
// TODO Errors thrown again after reset are caught
// TODO Nested error boundaries if a fallback throws
});
Loading