fix: speed up iOS text entry#1139
Merged
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks: no changes in the largest emitted chunks. |
thymikee
commented
Jul 7, 2026
thymikee
left a comment
Member
Author
There was a problem hiding this comment.
Reviewed the iOS text-entry speedup. The phase-marker logging, the keyboard-visible fast paths, and the switch to XCUIElement.typeText for concrete targets all look reasonable. One correctness concern on the verify/repair refactor — left it inline.
Generated by Claude Code
Member
Author
|
Reviewed #1139 at head Checked:
Residual risk: I did not rerun the simulator benchmark locally in this coordinator worktree; I am relying on the PR-provided Settings/Bluesky/test-app evidence plus green CI for maintainer judgment. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1108 by removing unnecessary iOS text-entry waits while preserving the existing “type first letter, wait, then type the rest” behavior for reliable search fields.
Changes:
AGENT_DEVICE_RUNNER_TEXT_ENTRY_PHASEmarkers around focus, clear, type, warmup, verify, and total phasesXCUIElement.typeTextso visible-keyboard refills stay scoped to the tapped field without a full focus timeoutMeasurements
Median wall-clock samples from iOS simulator runs:
Rejected experiments:
Validation
pnpm build:xcuitestgit diff --checkpnpm test-app:maestro:ios --close -- --udid C25DBB5B-9254-4293-A8D5-2785C78DE03A --state-dir /private/tmp/agent-device-test-app-maestro --artifacts-dir .tmp/issue-1108/maestro-ios --timeout 180000Checkout formMaestro flow passed in 22.8s.--closecleanup does not forward the custom state dir.Follow-up note: repeated clean reruns of the stock Expo dev-client Maestro flow later hit test-app environment issues outside this text-entry path:
launchApp clearStatereturned to the Expo dev launcher unless the runtime state was warm, andsimctl get_app_container ... dataeventually returned a missing simulator data-container path.