Skip to content

fix: speed up iOS text entry #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 2 commits into from
Jul 7, 2026
+207 −47
Merged

fix: speed up iOS text entry #1139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f862f5f
fix: speed up iOS text entry
thymikee Jul 7, 2026
6036572
fix: reverify settled iOS text entry
thymikee Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion apple-runner/AgentDeviceRunner/AgentDeviceRunnerUITests/RunnerTests+CommandExecution.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1269,6 +1269,7 @@ extension RunnerTests {
let delaySeconds = Double(max(command.delayMs ?? 0, 0)) / 1000.0
let textEntryMode = resolveTextEntryMode(command)
let target: TextEntryTarget
let focusStartedAt = Date()
if let selectorKey = command.selectorKey, let selectorValue = command.selectorValue {
let match = findElement(
app: activeApp,
Expand All @@ -1289,6 +1290,13 @@ extension RunnerTests {
} else {
target = focusTextInputForTextEntry(app: activeApp, x: command.x, y: command.y)
}
NSLog(
"AGENT_DEVICE_RUNNER_TEXT_ENTRY_PHASE commandId=%@ phase=focus durationMs=%.1f chars=%d mode=%@",
command.commandId ?? "",
Date().timeIntervalSince(focusStartedAt) * 1000.0,
text.count,
textEntryModeName(textEntryMode)
)
if textEntryMode == .replacement {
guard target.element != nil else {
let message =
Expand All @@ -1303,7 +1311,8 @@ extension RunnerTests {
target: target,
text: text,
delaySeconds: delaySeconds,
repairMode: textEntryMode
repairMode: textEntryMode,
commandId: command.commandId
)
if textResult.verified == false {
let expected = textResult.expectedText ?? ""
Expand Down
Loading
Loading