Add Daml for featured app weights#6178
Conversation
| where | ||
| signatory dso | ||
| observer if providerIsObserver then [provider] ++ optionalToList beneficiary else [] | ||
| observer if providerIsObserver then provider :: optionalToList beneficiary else [] |
There was a problem hiding this comment.
get rid of hlint complaint :/
There was a problem hiding this comment.
wondering if we should either enforce those in CI or just fully disable them, I don't think I personally found them to be all that useful
meiersi-da
added this to the
Traffic-Based App Rewards M3: On-Ledger Reward Workflow, Dry-Run, and MainNet Deployment milestone
meiersi-da
force-pushed
the
meiersi/poc-featured-app-weights
branch
from
939952a to
2eb630e
Compare
|
@moritzkiefer-da : could I ask for a review? Keeping it in draft state so it doesn't get merged too early, but otherwise it seems to be ready. |
moritzkiefer-da
left a comment
moritzkiefer-da
left a comment
There was a problem hiding this comment.
nice thanks! looks pretty straightforward. Probably want to add release notes before merging
| where | ||
| signatory dso | ||
| observer if providerIsObserver then [provider] ++ optionalToList beneficiary else [] | ||
| observer if providerIsObserver then provider :: optionalToList beneficiary else [] |
There was a problem hiding this comment.
wondering if we should either enforce those in CI or just fully disable them, I don't think I personally found them to be all that useful
Yeah, I think we should disable them. |
Fixes #6177 [ci] Signed-off-by: Simon Meier <simon@digitalasset.com>
meiersi-da
force-pushed
the
meiersi/poc-featured-app-weights
branch
from
36fce0f to
5ef75b9
Compare
3 participants
Fixes #6177 [no ci]
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines