normalize standards#1733
Merged
Merged
Conversation
RamilCDISC
reviewed
May 14, 2026
RamilCDISC
left a comment
RamilCDISC
left a comment
Collaborator
There was a problem hiding this comment.
Should we add a minimal regression test so in future if we update it can catch regressions like the one reported in connected ticket?
Collaborator
Author
|
@RamilCDISC the gist I got was the test that runs all rules would make this need obsolete (we can shoehorn some sendig-dart rules into this test). I think we are good for now |
RamilCDISC
approved these changes
May 17, 2026
RamilCDISC
left a comment
RamilCDISC
left a comment
Collaborator
There was a problem hiding this comment.
The PR adds normalization and missing standards for processing the standards name supplied from the CLI. The updates were validate by:
- Reviewing the PR for any unwanted code or comments.
- Reviewing the PR logic in accordance with AC.
- Ensuring all unit and regression testing pass.
- Ensuring the updated functionality and function calls are updated through out the codebase.
- Running manual testing using CLI to ensure the bug reported in the AC is not reproducible with updated changes.
gerrycampion
approved these changes
Jun 5, 2026
SFJohnson24
pushed a commit
that referenced
this pull request
Jun 22, 2026
StandardTypes is the allow-list core.py uses to validate -s/--standard. It lists adamig but not the other six ADaM products in ADAM_PRODUCTS (adam-adae, adam-md, adam-nca, adam-occds, adam-tte, adam-poppk), which are already handled by normalize_standard_input(). As a result a command such as `-s adam-tte` is rejected before the engine runs, even though the engine supports it. Add the six products to StandardTypes, completing the normalization from #1733 (which added adamig and the sendig-* products), and add a test asserting the gate stays in sync with ADAM_PRODUCTS. Signed-off-by: Antony Bevan <antonymichealbevan04@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.