fix: remove unsupported dd.DataFrame type hint in parquet_reader#1774
Merged
SFJohnson24 merged 2 commits intoJun 22, 2026
Merged
Conversation
Contributor
Author
|
@SFJohnson24 see next commit for pandas 3 upgrade from #1745 |
Draft
Collaborator
|
passes test suite: see #1775, high level review, pilot study test. |
SFJohnson24
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
Union[pd.DataFrame, dd.DataFrame]type hint from_format_floatsin parquet_reader. This method calls.map()which is only available onpd.DataFrame— it was never called with a dask DataFrame. TheUniontype hint pulls indd.DataFramewhich pandas 3.0 doesn't support in the same way, and the unused branch masks a type error.Tested scenarios: