Skip to content

fix: remove unsupported dd.DataFrame type hint in parquet_reader #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SFJohnson24 merged 2 commits into from
Jun 22, 2026
+1 −4
Merged

fix: remove unsupported dd.DataFrame type hint in parquet_reader #1774

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a5d334
fix: remove unsupported dd.DataFrame type in parquet_reader
filippsatverily May 22, 2026
e2d7164
Merge branch 'main' into filipps/pandas3-fix-parquet-reader-type
SFJohnson24 Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions cdisc_rules_engine/services/data_readers/parquet_reader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
from io import BytesIO
from typing import Union

import pandas as pd
import dask.dataframe as dd
Expand Down Expand Up @@ -29,9 +28,7 @@ def from_file(self, file_path):
file_path
)

def _format_floats(
self, dataframe: Union[pd.DataFrame, dd.DataFrame]
) -> Union[pd.DataFrame, dd.DataFrame]:
def _format_floats(self, dataframe: pd.DataFrame) -> pd.DataFrame:
return dataframe.map(lambda x: round(x, 15) if isinstance(x, float) else x)

def _read_dask(self, file_path):
Expand Down
Loading