fix: replace Dask GroupBy path in Distinct (.apply(set) fails in pandas 3.0)#1781
Open
filippsatverily wants to merge 2 commits into
Open
fix: replace Dask GroupBy path in Distinct (.apply(set) fails in pandas 3.0)#1781filippsatverily wants to merge 2 commits into
filippsatverily wants to merge 2 commits into
Conversation
filippsatverily
force-pushed
the
filipps/pandas3-fix-distinct-groupby
branch
from
e7ffcc5 to
444d277
Compare
Contributor
Author
|
@SFJohnson24 I'm a bit out of my depth on this one TBH, please LMK if this PR has problems I'm not seeing. |
This was referenced Jun 23, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pandas 3.0 changes the behavior of
.apply(set)/.apply(list)on a GroupBy, returning a DataFrame instead of a Series. This breaks the Daskelsebranch inDistinct._execute_operation.Instead of adding a Dask-specific code path, this materializes dask DataFrames to pandas at the top of the method, letting the existing pandas groupby/agg logic handle everything. This eliminates the Dask-specific
elsebranch entirely and also resolves 11 dask GroupByFutureWarninginstances (145 → 134 warnings).Tested scenarios: