Skip to content

fix: replace Dask GroupBy path in Distinct (.apply(set) fails in pandas 3.0) #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
filippsatverily wants to merge 4 commits into from
+4 −8
Closed

fix: replace Dask GroupBy path in Distinct (.apply(set) fails in pandas 3.0) #1781

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
444d277
fix: replace Dask GroupBy path in Distinct (.apply(set) fails in pand…
filippsatverily May 22, 2026
0c785ac
Merge branch 'main' into filipps/pandas3-fix-distinct-groupby
SFJohnson24 Jun 23, 2026
2642ace
style: apply black formatting to distinct.py
filippsatverily Jun 24, 2026
8f72715
Merge branch 'filipps/pandas3-fix-distinct-groupby' of ssh://github.c…
filippsatverily Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions cdisc_rules_engine/operations/distinct.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import pandas as pd
from cdisc_rules_engine.models.dataset.pandas_dataset import PandasDataset
from cdisc_rules_engine.operations.base_operation import BaseOperation


Expand All @@ -19,6 +20,8 @@ def _execute_operation(self):
result = self.params.dataframe
if self.params.filter:
result = self._filter_data(result)
if hasattr(result.data, "compute"):
result = PandasDataset(result.data.compute())
value_is_reference = getattr(self.params, "value_is_reference", False)
if not self.params.grouping:
if value_is_reference:
Expand Down Expand Up @@ -57,17 +60,10 @@ def get_existing_column_names(group):
)

result = grouped.apply(get_existing_column_names).reset_index()
elif isinstance(result.data, pd.DataFrame):
else:
result = grouped.data[self.params.target].agg(
self._unique_values_for_column
)
else:
result = (
grouped.data[self.params.target]
.unique()
.rename({self.params.target: self.params.operation_id})
)
result = result.apply(list).to_frame().reset_index()
return result

def _get_referenced_datasets(self):
Expand Down