CFE-4550: Added findlocalgroups() policy function#5882
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
victormlg
force-pushed
the
findlocalgroups
branch
2 times, most recently
from
ee9533b to
4753573
Compare
larsewi
requested changes
Sep 23, 2025
victormlg
force-pushed
the
findlocalgroups
branch
from
4753573 to
47d83fa
Compare
victormlg
force-pushed
the
findlocalgroups
branch
3 times, most recently
from
2f96295 to
a243d85
Compare
larsewi
requested changes
Sep 30, 2025
craigcomstock
approved these changes
Oct 1, 2025
craigcomstock
left a comment
craigcomstock
left a comment
Contributor
There was a problem hiding this comment.
Yeah, looks good with a few comments.
|
|
||
| # using regex | ||
| "simple_regex" slist => { "name=roo.*" }; | ||
| "number_regex" slist => { "gid=0.*" }; |
Contributor
There was a problem hiding this comment.
I see the number regex, what about character classes like [0-9] and such?
Contributor
Author
There was a problem hiding this comment.
The test is very limited because I want it to be predictable. For now the only matching group is root
Ticket: CFE-4550 Changelog: Title Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
findlocalgroups
branch
from
a243d85 to
eacbf8e
Compare
larsewi
requested changes
Oct 2, 2025
larsewi
left a comment
larsewi
left a comment
Contributor
There was a problem hiding this comment.
Looks like you have a failing acceptance test
Ticket: CFE-4550 Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
findlocalgroups
branch
from
eacbf8e to
2dd377c
Compare
larsewi
approved these changes
Oct 2, 2025
Contributor
|
@cf-bottom Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/12793/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12793/ |
olehermanse
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.