Add country field and support more fields in person CSV import/export#1100
Merged
Conversation
Optional nullable ISO 3166-1 alpha-2 `country` (carbon footprint plugin): validated/uppercased, set via POST/PUT and SAML SSO, kept out of the minimal payload.
Import/export country, position, seniority, daily salary, studio and departments; invalid values fail the row (400). Typed columns accept the human label or the stored code, and studio/department names match exactly (case-sensitive). Factor the ISO 3166-1 country validation into a single normalize_country helper shared by the model, API, CSV import and SAML SSO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Solution
countrycolumn on Person, validated and uppercased, settable via POST/PUT and SAML SSO, and kept out of the minimal (non-manager) payload.normalize_countryhelper shared by the model validator (silently discards), the API guard (400) and the CSV import (fails the row).countrycolumn.