fix(auth): let chainctl write to terminal for interactive login#2276
Merged
Conversation
If I'm not authenticated already, `melange` will hang when I start a build that requires auth. I can see that it has forked a `chainctl` process, which I run in `--headless` mode, but no device-login URL gets emitted to my terminal. This is because `apko` is discarding stderr. Stream chainctl's stderr to the terminal when stderr is a TTY, so the login URL (and any errors) are visible. Keep discarding it in non-interactive contexts (CI/logs) to preserve the original intent. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: dann frazier <dann.frazier@chainguard.dev>
b1c5b33 to
76d9b9f
Compare
EyeCantCU
approved these changes
Jun 12, 2026
EyeCantCU
left a comment
Member
There was a problem hiding this comment.
Thank you, thank you, thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I'm not authenticated already,
melangewill hang when I start a build that requires auth. I can see that it has forked achainctlprocess, which I run in--headlessmode, but no device-login URL gets emitted to my terminal. This is becauseapkois discarding stderr.Stream chainctl's stderr to the terminal when stderr is a TTY, so the login URL (and any errors) are visible. Keep discarding it in non-interactive contexts (CI/logs) to preserve the original intent.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: dann frazier <dann.frazier@chainguard.dev>