Skip to content

fix(auth): let chainctl write to terminal for interactive login #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dannf merged 1 commit into from
Jun 12, 2026
+10 −1
Merged

fix(auth): let chainctl write to terminal for interactive login #2276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ require (
golang.org/x/oauth2 v0.36.0
golang.org/x/sync v0.20.0
golang.org/x/sys v0.46.0
golang.org/x/term v0.43.0
golang.org/x/time v0.15.0
google.golang.org/api v0.280.0
gopkg.in/ini.v1 v1.67.3
Expand Down
10 changes: 9 additions & 1 deletion pkg/apk/auth/auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (

"github.com/chainguard-dev/clog"
"golang.org/x/oauth2"
"golang.org/x/term"
"golang.org/x/time/rate"
)

Expand Down Expand Up @@ -102,7 +103,14 @@ func (c CGRAuth) AddAuth(ctx context.Context, req *http.Request) error {

sometimes.Do(func() {
cmd := exec.CommandContext(ctx, "chainctl", "auth", "token", "--audience", host) //#nosec G702 -- host is from env/default, passed as argv (no shell)
cmd.Stderr = io.Discard // Don't pollute logs when things fail
// If stderr is a terminal, let chainctl write to it so it can prompt
// interactively (e.g. emit a device-login URL when running headless).
// Otherwise discard it to avoid polluting logs when things fail.
if term.IsTerminal(int(os.Stderr.Fd())) {
cmd.Stderr = os.Stderr
} else {
cmd.Stderr = io.Discard
}
out, err := cmd.Output()
if err != nil {
// Document that automatic auth failed and how to reproduce.
Expand Down
Loading