feat(chart): show real endpoints in Helm post-install notes

[ghophp]

Closes #97

Summary

The Helm chart NOTES.txt previously showed hardcoded placeholder endpoints (my-controlplane.acme.com:80). It now detects the actual service configuration (Ingress, LoadBalancer, NodePort, or ClusterIP) for both the Control Plane and Artifact CAS gRPC services and shows actionable connection instructions.

• When both endpoints use Ingress, a single ready-to-use chainloop config save command is shown with real hostnames
• For LoadBalancer/NodePort, kubectl commands to discover the external IP/port are provided
• For ClusterIP (default), kubectl port-forward instructions are shown
• The --insecure flag is only included when at least one endpoint lacks TLS
• Follows the same pattern used by Bitnami charts

Example output

Default (ClusterIP):

###########################################################################
  CONFIGURE CLI
###########################################################################

To configure the CLI, you need the Control Plane and Artifact CAS gRPC endpoints.

1. The Control Plane gRPC API is not externally accessible (ClusterIP). Use port-forwarding:

     kubectl port-forward --namespace default svc/test-chainloop-controlplane-api 9000:80 &

2. The Artifact CAS gRPC API is not externally accessible (ClusterIP). Use port-forwarding:

     kubectl port-forward --namespace default svc/test-chainloop-cas-api 9001:80 &

3. Configure the CLI:

     chainloop --insecure config save \
       --control-plane localhost:9000 \
       --artifact-cas localhost:9001

Ingress with TLS:

###########################################################################
  CONFIGURE CLI
###########################################################################

Configure the CLI to point to this instance:

  chainloop config save \
    --control-plane api.cp.example.com:443 \
    --artifact-cas api.cas.example.com:443

Helm unit tests

Added snapshot tests using helm-unittest with matchSnapshotRaw covering all 6 service type combinations (ClusterIP, Ingress, Ingress+TLS, LoadBalancer, NodePort, mixed). The tests are opt-in for now and not part of the CI pipeline. To run them locally:

helm plugin install https://github.com/helm-unittest/helm-unittest.git
helm unittest deployment/chainloop

Team: worth discussing whether we want to add helm unittest to the CI pipeline and helm plugin install to make init so these run automatically going forward.

[cubic-dev-ai]

No issues found across 4 files

_{Auto-approved: This PR enhances the Helm chart's post-installation instructions (NOTES.txt) with dynamic endpoint detection and adds helm-unittest snapshots. It does not modify core application or infrastructure逻辑.}

[migmartri]

Thanks for your contribution!

Just added a commment re: reusability of existing codebase. We might have external_urls for both controlplane and cas apis that are configuration aware already and just need to be used.

[philiposs]

Hi, thanks for the contribution, i would create a new PR with implementation of unit tests as they are not covered right now (and are a big thing) and keep only NOTES.txt changes in this one.

[ghophp]

Hey @migmartri @filip7656, thanks for the feedback! I've addressed both points:

• Extracted the gRPC endpoint resolution into reusable helper templates (chainloop.controlplane.external_grpc_url and chainloop.cas.external_grpc_url) in _helpers.tpl, following the same pattern as the existing HTTP helpers
• Refactored NOTES.txt to use those helpers instead of inlining the logic
• Removed the helm-unittest introduction from this PR to keep the scope focused

[cubic-dev-ai]

2 issues found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="deployment/chainloop/templates/NOTES.txt">

<violation number="1" location="deployment/chainloop/templates/NOTES.txt:15">
P2: Inconsistent port resolution: other templates (`service-grpc.yaml`, `configmap.yaml`) still use `coalesce .Values.controlplane.serviceAPI.port .Values.controlplane.serviceAPI.ports.http` to support the legacy singular `.port` key. Dropping the `coalesce` here means the NOTES.txt may display an incorrect port when a user overrides `.serviceAPI.port`.</violation>

<violation number="2" location="deployment/chainloop/templates/NOTES.txt:19">
P2: Same inconsistency for the CAS port: `cas/service-grpc.yaml` and `controlplane/configmap.yaml` still use `coalesce .Values.cas.serviceAPI.port .Values.cas.serviceAPI.ports.http`. Dropping `coalesce` here can show wrong port in the notes.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[philiposs]

LGTM.
Final last touch i would move CONFIGURE CLI section at the bottom, after an installation there is a lot of output and you can miss it
@migmartri what do you think?

[migmartri]

@philiposs makes sense to me