Skip to content

fix(chart): use correct serviceAPI.ports.http key in templates#2819

Merged
migmartri merged 2 commits into
chainloop-dev:mainfrom
ghophp:ghophp/fix-serviceapi-port-key
Mar 6, 2026
Merged

fix(chart): use correct serviceAPI.ports.http key in templates#2819
migmartri merged 2 commits into
chainloop-dev:mainfrom
ghophp:ghophp/fix-serviceapi-port-key

Conversation

@ghophp

@ghophp ghophp commented Mar 5, 2026

Copy link
Copy Markdown
Contributor
  • Fix incorrect .Values.controlplane.serviceAPI.port and .Values.cas.serviceAPI.port references in Helm templates
  • The serviceAPI.port key does not exist in the values schema — the correct path is serviceAPI.ports.http
  • The coalesce fallback silently masked the issue since nil was always skipped at runtime

Spotted during review of #2801, these occurrences pre-date that PR and exist in service-grpc.yaml (controlplane and CAS) and configmap.yaml.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@philiposs

Copy link
Copy Markdown
Contributor

Thanks for the PR, please bump the chart version and feel free to merge

ghophp added 2 commits March 6, 2026 10:58
The serviceAPI.port key does not exist in the values schema. Replace
the coalesce fallback with the correct serviceAPI.ports.http reference
in service-grpc.yaml and configmap.yaml templates.

Signed-off-by: Guilherme Oliveira <ghophp@gmail.com>
Signed-off-by: Guilherme Oliveira <ghophp@gmail.com>
@ghophp ghophp force-pushed the ghophp/fix-serviceapi-port-key branch from 002a6ed to d4d7617 Compare March 6, 2026 10:00
@ghophp

ghophp commented Mar 6, 2026

Copy link
Copy Markdown
Contributor Author

@filip7656 At least 1 approving review is required by reviewers with write access. cc @migmartri

@migmartri migmartri merged commit dd5b602 into chainloop-dev:main Mar 6, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants