docs: add build and packaging overview#2820
Merged
migmartri merged 2 commits intoMar 6, 2026
Merged
Conversation
Signed-off-by: Miguel Martinez <miguel@chainloop.dev> Entire-Checkpoint: c53099c636f6
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/build-and-packaging.md">
<violation number="1" location="docs/build-and-packaging.md:112">
P2: Documented make target `build_devel_container_images` doesn't exist — the actual Makefile target is `build_devel_container_mages` (typo, missing 'i'). Anyone following this doc will get an error. Either update the docs to match the Makefile, or (preferably) fix the typo in the Makefile and keep the docs as-is.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| make build_devel | ||
|
|
||
| # Build binaries + container images locally (no signing) | ||
| make build_devel_container_images |
There was a problem hiding this comment.
P2: Documented make target build_devel_container_images doesn't exist — the actual Makefile target is build_devel_container_mages (typo, missing 'i'). Anyone following this doc will get an error. Either update the docs to match the Makefile, or (preferably) fix the typo in the Makefile and keep the docs as-is.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At docs/build-and-packaging.md, line 112:
<comment>Documented make target `build_devel_container_images` doesn't exist — the actual Makefile target is `build_devel_container_mages` (typo, missing 'i'). Anyone following this doc will get an error. Either update the docs to match the Makefile, or (preferably) fix the typo in the Makefile and keep the docs as-is.</comment>
<file context>
@@ -0,0 +1,113 @@
+make build_devel
+
+# Build binaries + container images locally (no signing)
+make build_devel_container_images
+```
</file context>
Signed-off-by: Miguel Martinez <miguel@chainloop.dev> Entire-Checkpoint: 673d9d0a9d7e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a high-level overview of how Chainloop is built and packaged: GoReleaser, container images, dependency image rebuilds from Bitnami sources, Helm chart structure, and chart bumping on release.