Skip to content

Comments

Fixup lock handling in limit enforcer and compile cache.#6121

Open
mar-cf wants to merge 1 commit intomainfrom
mar/lockfix
Open

Fixup lock handling in limit enforcer and compile cache.#6121
mar-cf wants to merge 1 commit intomainfrom
mar/lockfix

Conversation

@mar-cf
Copy link
Contributor

@mar-cf mar-cf commented Feb 20, 2026

No description provided.

@mar-cf mar-cf requested a review from jasnell February 20, 2026 17:41
@mar-cf mar-cf requested review from a team as code owners February 20, 2026 17:41
@mar-cf
Copy link
Contributor Author

mar-cf commented Feb 20, 2026

@jasnell did we land on a compile time catch for this?

@jasnell
Copy link
Collaborator

jasnell commented Feb 20, 2026

did we land on a compile time catch for this?

Not that I'm aware of. @danlapid was looking into it

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 20, 2026

Merging this PR will not alter performance

✅ 70 untouched benchmarks
⏩ 129 skipped benchmarks1


Comparing mar/lockfix (70da2f6) with main (edacbb5)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@danlapid
Copy link
Collaborator

@jasnell
Copy link
Collaborator

jasnell commented Feb 21, 2026

@mar-cf ... you'll likely need to rebase this on main to deal with spurious test failure on widows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants