feat: enable save button only when form is modified#5927
Merged
Conversation
Signed-off-by: yuda <yuda@megazone.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Contributor
|
✅ There are no commits in this PR that require review. |
Contributor
|
🎉 @skdud4659 has been randomly selected as the reviewer! Please review. 🙏 |
There was a problem hiding this comment.
Pull Request Overview
This PR ensures the Save button is only enabled when form values differ from the loaded configuration.
- Adds a new
isFormChangedcomputed property that deep-compares form state against the initial config - Updates the Save button’s
disabledbinding to include!isFormChanged - Imports
isEqualfrom lodash for comparison
Comments suppressed due to low confidence (2)
apps/web/src/services/cost-explorer/components/AdvancedSettingsCostReportConfiguration.vue:67
- [nitpick] The name
isFormChangedis a bit generic; consider renaming toisFormModifiedorhasUnsavedChangesfor clearer intent.
const isFormChanged = computed<boolean>(() => !isEqual(state.selectedLanguage, costReportConfig.value?.language)
apps/web/src/services/cost-explorer/components/AdvancedSettingsCostReportConfiguration.vue:289
- There's no existing test to verify the Save button toggles based on form modifications; adding a unit or integration test for this behavior would help prevent regressions.
:disabled="isSaveDisabled || !isFormChanged"
Comment on lines
+67
to
73
| const isFormChanged = computed<boolean>(() => !isEqual(state.selectedLanguage, costReportConfig.value?.language) | ||
| || !isEqual(state.selectedCurrency, costReportConfig.value?.currency) | ||
| || !isEqual(Number(issueDate.value), Number(costReportConfig.value?.issue_day)) | ||
| || !isEqual(state.lastDayOfMonth, !!costReportConfig.value?.is_last_day) | ||
| || !isEqual(state.enableAdjustments, !!costReportConfig.value?.adjustment_options?.enabled) | ||
| || !isEqual(Number(manualAdjustablePeriod.value), Number(costReportConfig.value?.adjustment_options?.period))); | ||
|
|
There was a problem hiding this comment.
Manually comparing each field can become hard to maintain as new settings are added; consider capturing the form state as an object and doing a single deep compare against a snapshot of the initial values.
Suggested change
| const isFormChanged = computed<boolean>(() => !isEqual(state.selectedLanguage, costReportConfig.value?.language) | |
| || !isEqual(state.selectedCurrency, costReportConfig.value?.currency) | |
| || !isEqual(Number(issueDate.value), Number(costReportConfig.value?.issue_day)) | |
| || !isEqual(state.lastDayOfMonth, !!costReportConfig.value?.is_last_day) | |
| || !isEqual(state.enableAdjustments, !!costReportConfig.value?.adjustment_options?.enabled) | |
| || !isEqual(Number(manualAdjustablePeriod.value), Number(costReportConfig.value?.adjustment_options?.period))); | |
| const initialFormState = computed(() => ({ | |
| selectedLanguage: costReportConfig.value?.language, | |
| selectedCurrency: costReportConfig.value?.currency, | |
| issueDate: Number(costReportConfig.value?.issue_day), | |
| lastDayOfMonth: !!costReportConfig.value?.is_last_day, | |
| enableAdjustments: !!costReportConfig.value?.adjustment_options?.enabled, | |
| manualAdjustablePeriod: Number(costReportConfig.value?.adjustment_options?.period), | |
| })); | |
| const isFormChanged = computed<boolean>(() => !isEqual(state, initialFormState.value)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip Review (optional)
style,chore,ci,test,docs)Description (optional)
Things to Talk About (optional)