Skip to content

feat: enable save button only when form is modified #5927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuda110 merged 1 commit into from
Jun 4, 2025
Merged

feat: enable save button only when form is modified #5927

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions apps/web/src/services/cost-explorer/components/AdvancedSettingsCostReportConfiguration.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { computed, reactive, watch } from 'vue';

import { useMutation, useQueryClient } from '@tanstack/vue-query';
import dayjs from 'dayjs';
import { map } from 'lodash';
import { isEqual, map } from 'lodash';

import {
PFieldGroup,
Expand Down Expand Up @@ -64,6 +64,12 @@ const isSaveDisabled = computed<boolean>(() => {
return !isAllValid.value;
});
const currencyMenuList = Object.values(CURRENCY).map((currency) => ({ label: `${CURRENCY_SYMBOL[currency]} ${currency}`, name: currency }));
const isFormChanged = computed<boolean>(() => !isEqual(state.selectedLanguage, costReportConfig.value?.language)
|| !isEqual(state.selectedCurrency, costReportConfig.value?.currency)
|| !isEqual(Number(issueDate.value), Number(costReportConfig.value?.issue_day))
|| !isEqual(state.lastDayOfMonth, !!costReportConfig.value?.is_last_day)
|| !isEqual(state.enableAdjustments, !!costReportConfig.value?.adjustment_options?.enabled)
|| !isEqual(Number(manualAdjustablePeriod.value), Number(costReportConfig.value?.adjustment_options?.period)));

Comment on lines +67 to 73
Copy link

Copilot AI Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually comparing each field can become hard to maintain as new settings are added; consider capturing the form state as an object and doing a single deep compare against a snapshot of the initial values.

Suggested change
const isFormChanged = computed<boolean>(() => !isEqual(state.selectedLanguage, costReportConfig.value?.language)
|| !isEqual(state.selectedCurrency, costReportConfig.value?.currency)
|| !isEqual(Number(issueDate.value), Number(costReportConfig.value?.issue_day))
|| !isEqual(state.lastDayOfMonth, !!costReportConfig.value?.is_last_day)
|| !isEqual(state.enableAdjustments, !!costReportConfig.value?.adjustment_options?.enabled)
|| !isEqual(Number(manualAdjustablePeriod.value), Number(costReportConfig.value?.adjustment_options?.period)));
const initialFormState = computed(() => ({
selectedLanguage: costReportConfig.value?.language,
selectedCurrency: costReportConfig.value?.currency,
issueDate: Number(costReportConfig.value?.issue_day),
lastDayOfMonth: !!costReportConfig.value?.is_last_day,
enableAdjustments: !!costReportConfig.value?.adjustment_options?.enabled,
manualAdjustablePeriod: Number(costReportConfig.value?.adjustment_options?.period),
}));
const isFormChanged = computed<boolean>(() => !isEqual(state, initialFormState.value));

Copilot uses AI. Check for mistakes.
const {
forms: {
Expand Down Expand Up @@ -280,7 +286,7 @@ watch(() => costReportConfig.value, (val) => {
<div class="mt-8">
<p-button
style-type="primary"
:disabled="isSaveDisabled"
:disabled="isSaveDisabled || !isFormChanged"
@click="handleSave"
>
{{ $t('LADING.SAVE_CHANGES') }}
Expand Down
Loading