chore: switch to @tony.ganchev/eslint-plugin-header#73
Merged
amanabiy merged 1 commit intocloudscape-design:mainfrom Mar 26, 2026
Merged
chore: switch to @tony.ganchev/eslint-plugin-header#73amanabiy merged 1 commit intocloudscape-design:mainfrom
amanabiy merged 1 commit intocloudscape-design:mainfrom
Conversation
This was referenced Mar 16, 2026
tonyganchev
added a commit
to tonyganchev/browser-test-tools
that referenced
this pull request
Mar 16, 2026
Hi, team, I noticed you are using eslint-plugin-header on ESLint 8. I forked @tony.ganchev/eslint-plugin-header mid-2024 to add support for ESLint 9 and hoped it would be a temporary measure but since the original has not been updated for five years I decided to continue improving the new plugin and have been doing so for the last two years. Specific improvements include: - full JSON schema for validating the configuration. - fixed multiple bugs with the behavior of the plugin on Windows. - many other bug-fixes. - improved autofixing and error-reporting behavior. - added support for leading pragma comments before the header such as `@jest-environment`. I've sent PR proposals to other projects in the _cloudscape-design_ space: - cloudscape-design/board-components#401 - cloudscape-design/chart-components#185 - cloudscape-design/code-view#122 - cloudscape-design/collection-hooks#136 - cloudscape-design/component-toolkit#200 - cloudscape-design/components#4308 - cloudscape-design/demos#243 - cloudscape-design/global-styles#73 - cloudscape-design/jest-preset#58 - cloudscape-design/test-utils#114 - cloudscape-design/theming-core#148 Looking forward to your feedback.
tonyganchev
added a commit
to tonyganchev/documenter
that referenced
this pull request
Mar 16, 2026
Hi, team, I noticed you are using _eslint-plugin-header_ with the schema-turn-off workaround to support ESLint 9. I forked _@tony.ganchev/eslint-plugin-header_ mid-2024 to address this issue and hoped it would be a temporary measure but since the original has not been updated for five years I decided to continue improving the new plugin and have been doing so for the last two years. Specific improvements include: - full JSON schema for validating the configuration. - fixed multiple bugs with the behavior of the plugin on Windows. - many other bug-fixes. - improved autofixing and error-reporting behavior. - added support for leading pragma comments before the header such as `@jest-environment`. I've sent PR proposals to other projects in the cloudscape-design space: - cloudscape-design/board-components#401 - cloudscape-design/browser-test-tools#188 - cloudscape-design/chart-components#185 - cloudscape-design/code-view#122 - cloudscape-design/collection-hooks#136 - cloudscape-design/component-toolkit#200 - cloudscape-design/components#4308 - cloudscape-design/demos#243 - cloudscape-design/global-styles#73 - cloudscape-design/jest-preset#58 - cloudscape-design/theming-core#148 - cloudscape-design/test-utils#114 Looking forward to your feedback.
tonyganchev
added a commit
to tonyganchev/build-tools
that referenced
this pull request
Mar 16, 2026
Hi, team, I noticed you are using _eslint-plugin-header_ on ESLint 8. I forked _@tony.ganchev/eslint-plugin-header_ mid-2024 to add support for ESLint 9 and hoped it would be a temporary measure but since the original has not been updated for five years I decided to continue improving the new plugin and have been doing so for the last two years. Specific improvements include: - full JSON schema for validating the configuration. - fixed multiple bugs with the behavior of the plugin on Windows. - many other bug-fixes. - improved autofixing and error-reporting behavior. - added support for leading pragma comments before the header such as `@jest-environment`. I've sent PR proposals to other projects in the _cloudscape-design_ space: - cloudscape-design/board-components#401 - cloudscape-design/browser-test-tools#188 - cloudscape-design/chart-components#185 - cloudscape-design/code-view#122 - cloudscape-design/collection-hooks#136 - cloudscape-design/component-toolkit#200 - cloudscape-design/components#4308 - cloudscape-design/demos#243 - cloudscape-design/documenter#112 - cloudscape-design/global-styles#73 - cloudscape-design/jest-preset#58 - cloudscape-design/test-utils#114 - cloudscape-design/theming-core#148 Looking forward to your feedback.
tonyganchev
added a commit
to tonyganchev/chat-components
that referenced
this pull request
Mar 16, 2026
Hi, team, I noticed you are using _eslint-plugin-header_ on ESLint 8. I forked _@tony.ganchev/eslint-plugin-header_ mid-2024 to add support for ESLint 9 and hoped it would be a temporary measure but since the original has not been updated for five years I decided to continue improving the new plugin and have been doing so for the last two years. Specific improvements include: - full JSON schema for validating the configuration. - fixed multiple bugs with the behavior of the plugin on Windows. - many other bug-fixes. - improved autofixing and error-reporting behavior. - added support for leading pragma comments before the header such as `@jest-environment` or `eslint-env`. In the case of the current review, this allowed me to remove the `eslint-disable` directive from one file and reintroduce validation. I switched the configuration to use the new config format for v3.2.x as the leading comments feature is not supported by the array-based format inherited from _eslint-plugin-header_. I've sent PR proposals to other projects in the _cloudscape-design_ space: - cloudscape-design/board-components#401 - cloudscape-design/browser-test-tools#188 - cloudscape-design/chart-components#185 - cloudscape-design/code-view#122 - cloudscape-design/collection-hooks#136 - cloudscape-design/component-toolkit#200 - cloudscape-design/components#4308 - cloudscape-design/demos#243 - cloudscape-design/documenter#112 - cloudscape-design/global-styles#73 - cloudscape-design/jest-preset#58 - cloudscape-design/test-utils#114 - cloudscape-design/theming-core#148 Looking forward to your feedback.
tonyganchev
added a commit
to tonyganchev/documenter
that referenced
this pull request
Mar 24, 2026
Hi, team, I noticed you are using _eslint-plugin-header_ with the schema-turn-off workaround to support ESLint 9. I forked _@tony.ganchev/eslint-plugin-header_ mid-2024 to address this issue and hoped it would be a temporary measure but since the original has not been updated for five years I decided to continue improving the new plugin and have been doing so for the last two years. Specific improvements include: - full JSON schema for validating the configuration. - fixed multiple bugs with the behavior of the plugin on Windows. - many other bug-fixes. - improved autofixing and error-reporting behavior. - added support for leading pragma comments before the header such as `@jest-environment`. I've sent PR proposals to other projects in the cloudscape-design space: - cloudscape-design/board-components#401 - cloudscape-design/browser-test-tools#188 - cloudscape-design/chart-components#185 - cloudscape-design/code-view#122 - cloudscape-design/collection-hooks#136 - cloudscape-design/component-toolkit#200 - cloudscape-design/components#4308 - cloudscape-design/demos#243 - cloudscape-design/global-styles#73 - cloudscape-design/jest-preset#58 - cloudscape-design/theming-core#148 - cloudscape-design/test-utils#114 Looking forward to your feedback.
Hi, team, I noticed you are using _eslint-plugin-header_ with the schema-turn-off workaround to support ESLint 9. I forked _@tony.ganchev/eslint-plugin-header_ mid-2024 to address this issue and hoped it would be a temporary measure but since the original has not been updated for five years I decided to continue improving the new plugin and have been doing so for the last two years. Specific improvements include: - full JSON schema for validating the configuration. - fixed multiple bugs with the behavior of the plugin on Windows. - many other bug-fixes. - improved autofixing and error-reporting behavior. - added support for leading pragma comments before the header such as `@jest-environment`. I've sent PR proposals to other projects in the cloudscape-design space: - cloudscape-design/board-components#401 - cloudscape-design/chart-components#185 - cloudscape-design/code-view#122 - cloudscape-design/collection-hooks#136 - cloudscape-design/component-toolkit#200 - cloudscape-design/components#4308 - cloudscape-design/demos#243 - cloudscape-design/jest-preset#58 - cloudscape-design/test-utils#114 - cloudscape-design/theming-core#148 Looking forward to your feedback.
tonyganchev
added a commit
to tonyganchev/chat-components
that referenced
this pull request
Mar 24, 2026
Hi, team, I noticed you are using _eslint-plugin-header_ on ESLint 8. I forked _@tony.ganchev/eslint-plugin-header_ mid-2024 to add support for ESLint 9 and hoped it would be a temporary measure but since the original has not been updated for five years I decided to continue improving the new plugin and have been doing so for the last two years. Specific improvements include: - full JSON schema for validating the configuration. - fixed multiple bugs with the behavior of the plugin on Windows. - many other bug-fixes. - improved autofixing and error-reporting behavior. - added support for leading pragma comments before the header such as `@jest-environment` or `eslint-env`. In the case of the current review, this allowed me to remove the `eslint-disable` directive from one file and reintroduce validation. I switched the configuration to use the new config format for v3.2.x as the leading comments feature is not supported by the array-based format inherited from _eslint-plugin-header_. I've sent PR proposals to other projects in the _cloudscape-design_ space: - cloudscape-design/board-components#401 - cloudscape-design/browser-test-tools#188 - cloudscape-design/chart-components#185 - cloudscape-design/code-view#122 - cloudscape-design/collection-hooks#136 - cloudscape-design/component-toolkit#200 - cloudscape-design/components#4308 - cloudscape-design/demos#243 - cloudscape-design/documenter#112 - cloudscape-design/global-styles#73 - cloudscape-design/jest-preset#58 - cloudscape-design/test-utils#114 - cloudscape-design/theming-core#148 Looking forward to your feedback.
tonyganchev
added a commit
to tonyganchev/browser-test-tools
that referenced
this pull request
Mar 25, 2026
Hi, team, I noticed you are using eslint-plugin-header on ESLint 8. I forked @tony.ganchev/eslint-plugin-header mid-2024 to add support for ESLint 9 and hoped it would be a temporary measure but since the original has not been updated for five years I decided to continue improving the new plugin and have been doing so for the last two years. Specific improvements include: - full JSON schema for validating the configuration. - fixed multiple bugs with the behavior of the plugin on Windows. - many other bug-fixes. - improved autofixing and error-reporting behavior. - added support for leading pragma comments before the header such as `@jest-environment`. I've sent PR proposals to other projects in the _cloudscape-design_ space: - cloudscape-design/board-components#401 - cloudscape-design/chart-components#185 - cloudscape-design/code-view#122 - cloudscape-design/collection-hooks#136 - cloudscape-design/component-toolkit#200 - cloudscape-design/components#4308 - cloudscape-design/demos#243 - cloudscape-design/global-styles#73 - cloudscape-design/jest-preset#58 - cloudscape-design/test-utils#114 - cloudscape-design/theming-core#148 Looking forward to your feedback.
tonyganchev
added a commit
to tonyganchev/browser-test-tools
that referenced
this pull request
Mar 25, 2026
Hi, team, I noticed you are using eslint-plugin-header on ESLint 8. I forked @tony.ganchev/eslint-plugin-header mid-2024 to add support for ESLint 9 and hoped it would be a temporary measure but since the original has not been updated for five years I decided to continue improving the new plugin and have been doing so for the last two years. Specific improvements include: - full JSON schema for validating the configuration. - fixed multiple bugs with the behavior of the plugin on Windows. - many other bug-fixes. - improved autofixing and error-reporting behavior. - added support for leading pragma comments before the header such as `@jest-environment`. I've sent PR proposals to other projects in the _cloudscape-design_ space: - cloudscape-design/board-components#401 - cloudscape-design/chart-components#185 - cloudscape-design/code-view#122 - cloudscape-design/collection-hooks#136 - cloudscape-design/component-toolkit#200 - cloudscape-design/components#4308 - cloudscape-design/demos#243 - cloudscape-design/global-styles#73 - cloudscape-design/jest-preset#58 - cloudscape-design/test-utils#114 - cloudscape-design/theming-core#148 Looking forward to your feedback.
tonyganchev
added a commit
to tonyganchev/browser-test-tools
that referenced
this pull request
Mar 26, 2026
Hi, team, I noticed you are using eslint-plugin-header on ESLint 8. I forked @tony.ganchev/eslint-plugin-header mid-2024 to add support for ESLint 9 and hoped it would be a temporary measure but since the original has not been updated for five years I decided to continue improving the new plugin and have been doing so for the last two years. Specific improvements include: - full JSON schema for validating the configuration. - fixed multiple bugs with the behavior of the plugin on Windows. - many other bug-fixes. - improved autofixing and error-reporting behavior. - added support for leading pragma comments before the header such as `@jest-environment`. I've sent PR proposals to other projects in the _cloudscape-design_ space: - cloudscape-design/board-components#401 - cloudscape-design/chart-components#185 - cloudscape-design/code-view#122 - cloudscape-design/collection-hooks#136 - cloudscape-design/component-toolkit#200 - cloudscape-design/components#4308 - cloudscape-design/demos#243 - cloudscape-design/global-styles#73 - cloudscape-design/jest-preset#58 - cloudscape-design/test-utils#114 - cloudscape-design/theming-core#148 Looking forward to your feedback.
tonyganchev
added a commit
to tonyganchev/documenter
that referenced
this pull request
Mar 26, 2026
Hi, team, I noticed you are using _eslint-plugin-header_ with the schema-turn-off workaround to support ESLint 9. I forked _@tony.ganchev/eslint-plugin-header_ mid-2024 to address this issue and hoped it would be a temporary measure but since the original has not been updated for five years I decided to continue improving the new plugin and have been doing so for the last two years. Specific improvements include: - full JSON schema for validating the configuration. - fixed multiple bugs with the behavior of the plugin on Windows. - many other bug-fixes. - improved autofixing and error-reporting behavior. - added support for leading pragma comments before the header such as `@jest-environment`. I've sent PR proposals to other projects in the cloudscape-design space: - cloudscape-design/board-components#401 - cloudscape-design/browser-test-tools#188 - cloudscape-design/chart-components#185 - cloudscape-design/code-view#122 - cloudscape-design/collection-hooks#136 - cloudscape-design/component-toolkit#200 - cloudscape-design/components#4308 - cloudscape-design/demos#243 - cloudscape-design/global-styles#73 - cloudscape-design/jest-preset#58 - cloudscape-design/theming-core#148 - cloudscape-design/test-utils#114 Looking forward to your feedback.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
=======================================
Coverage 92.00% 92.00%
=======================================
Files 1 1
Lines 25 25
Branches 9 9
=======================================
Hits 23 23
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amanabiy
approved these changes
Mar 26, 2026
Contributor
Author
|
Thanks! ecosystem test for this project: tonyganchev/eslint-plugin-header#164 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, team,
I noticed you are using eslint-plugin-header with the schema-turn-off
workaround to support ESLint 9.
I forked @tony.ganchev/eslint-plugin-header mid-2024 to address this
issue and hoped it would be a temporary measure but since the original
has not been updated for five years I decided to continue improving the
new plugin and have been doing so for the last two years.
Specific improvements include:
@jest-environment.I've sent PR proposals to other projects in the cloudscape-design space:
Looking forward to your feedback.